Skip to content

Conversation

AFatmaa
Copy link

@AFatmaa AFatmaa commented Dec 29, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@AFatmaa AFatmaa added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 29, 2024
@illicitonion illicitonion added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 30, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally looking really good, good job!

fetch/index.html Outdated
<body>
<h1>XKCD Comic Viewer</h1>
<div id="comic-container">
<img id="comic-img" alt="XKCD Comic" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user, it's a little weird that when I first open the page it shows me a broken image... Can you think of a more natural effect to show users when they first load the page?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback! I understand that seeing a broken image initially can be confusing for users. I’ve updated the page so that a default placeholder image is displayed when the page first loads.
To be honest, this idea crossed my mind while writing the code, 🙈 but I didn’t think it through enough at the time.
Thanks again for making the code better! 🙌

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 30, 2024
@AFatmaa
Copy link
Author

AFatmaa commented Dec 30, 2024

Hi @illicitonion,

Thank you so much! I really appreciate your feedback. I'm glad you liked it, and I'll continue working to improve it further! 🌸

@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 31, 2024
@illicitonion
Copy link
Member

Looking good!

@AFatmaa
Copy link
Author

AFatmaa commented Dec 31, 2024

Hi @illicitonion,

Thank you so much for your guidance and support! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants