-
-
Notifications
You must be signed in to change notification settings - Fork 124
CYF London | Fatma Arslantas | Module-Data-Flows | Week 1 | Programmer Humour #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYF London | Fatma Arslantas | Module-Data-Flows | Week 1 | Programmer Humour #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generally looking really good, good job!
fetch/index.html
Outdated
<body> | ||
<h1>XKCD Comic Viewer</h1> | ||
<div id="comic-container"> | ||
<img id="comic-img" alt="XKCD Comic" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a user, it's a little weird that when I first open the page it shows me a broken image... Can you think of a more natural effect to show users when they first load the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback! I understand that seeing a broken image initially can be confusing for users. I’ve updated the page so that a default placeholder image is displayed when the page first loads.
To be honest, this idea crossed my mind while writing the code, 🙈 but I didn’t think it through enough at the time.
Thanks again for making the code better! 🙌
Hi @illicitonion, Thank you so much! I really appreciate your feedback. I'm glad you liked it, and I'll continue working to improve it further! 🌸 |
Looking good! |
Hi @illicitonion, Thank you so much for your guidance and support! 🙌 |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.