generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 125
London | 25-ITP-May | Halyna Kozlovska | Sprint 2 | Book Library #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f1b0058
fix the show of any books
halyna-k b5721ca
fix error in console when trying to add a book
halyna-k d2faec1
correct the author's name when creating a new book
halyna-k 385b33c
fix typo in delete button event listener
halyna-k 860f8f9
fix logic for displaying read/unread status
halyna-k a0ac705
refactor: improve book form and fix input types
halyna-k 74cbb72
refactor: clean up form submission logic and improve data handling
halyna-k ec63ddf
fix: make index.html W3C-valid HTML
halyna-k f2afb9f
refactor: improve book table rendering, validation, and naming
halyna-k e1d2581
add validation to ensure the pages input is a positive integer
halyna-k eeeeaee
clear table body in one step for faster rendering
halyna-k 5de7be7
Refactor render() to centralize cell creation and modularize button s…
halyna-k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,102 @@ | ||
| let myLibrary = []; | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| window.addEventListener("load", function () { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| true | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); | ||
| const book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true); | ||
| myLibrary.push(book1,book2); | ||
| } | ||
| render(); | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
| const form = document.getElementById("book-form"); | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const checkReadStatus = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| function submitNewBook() { | ||
| let title = titleInput.value.trim(); | ||
| let author = authorInput.value.trim(); | ||
| let pages = Number(pagesInput.value.trim()); | ||
| let isRead = checkReadStatus.checked; | ||
|
|
||
| if (!title || !author || !pages || !Number.isInteger(pages) || pages <= 0) { | ||
| alert("Please fill all fields correctly!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| } | ||
| const book = new Book(title, author, pages, isRead); | ||
| myLibrary.push(book); | ||
| render(); | ||
| form.reset(); | ||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.check = check; | ||
| form.addEventListener('submit', function(event) { | ||
| event.preventDefault(); | ||
| submitNewBook(); | ||
| }); | ||
|
|
||
| function createReadToggleButton(cell, book) { | ||
| const toggleBtn = document.createElement("button"); | ||
| toggleBtn.textContent = book.isRead ? "Yes" : "No"; | ||
| toggleBtn.className = "btn btn-success"; | ||
| toggleBtn.addEventListener("click", function () { | ||
| book.isRead = !book.isRead; | ||
| render(); | ||
| }); | ||
| cell.appendChild(toggleBtn); | ||
| } | ||
|
|
||
| function createDeleteButton(cell, book, index) { | ||
| const deleteBtn = document.createElement("button"); | ||
| deleteBtn.textContent = "Delete"; | ||
| deleteBtn.className = "btn btn-warning"; | ||
| deleteBtn.addEventListener("click", function () { | ||
| myLibrary.splice(index, 1); | ||
| render(); | ||
| alert(`You've deleted book with title: ${book.title}`); | ||
| }); | ||
| cell.appendChild(deleteBtn); | ||
| } | ||
|
|
||
| class Book { | ||
| constructor(title, author, pages, isRead) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = Number(pages); | ||
| this.isRead = isRead; | ||
| } | ||
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| const table = document.getElementById("display"); | ||
| const tableBody = table.querySelector("tbody"); | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| tableBody.innerHTML = ""; | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
| myLibrary.forEach((book, index) => { | ||
| const row = tableBody.insertRow(0); | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| const titleCell = row.insertCell(0); | ||
| const authorCell = row.insertCell(1); | ||
| const pagesCell = row.insertCell(2); | ||
| const readCell = row.insertCell(3); | ||
| const deleteCell = row.insertCell(4); | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| render(); | ||
| }); | ||
| titleCell.textContent = book.title; | ||
| authorCell.textContent = book.author; | ||
| pagesCell.textContent = book.pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| createReadToggleButton(readCell, book); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| }); | ||
| } | ||
| createDeleteButton(deleteCell, book, index); | ||
| }); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pagesInputcould be a value like"3.1416". Do we want to allow such value as page count?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjyuan Thanks for the great catch! I’ve updated the validation logic to require the page count to be a positive integer, preventing decimal values from being accepted.