London | ITP-May-2025 | Hibo Sharif | Module-Data-Flows | Programmer Humour #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script.js and style.css files
hibosharif202504
added
the
Needs Review
cjyuan
reviewed
Aug 9, 2025
fetch/programmer-humour/script.js
Outdated
Comment on lines
6
to
24
| function getComicData() { | ||
| fetch("https://xkcd.now.sh/?comic=latest") | ||
| .then(response => { | ||
| if (!response.ok) { | ||
| throw new Error(`Comic not available (status: ${response.status})`); | ||
| } | ||
|
|
||
| return response.json(); | ||
| }) | ||
| .then(data => { | ||
| console.log(data); | ||
| imgComic.src = data.img; | ||
| imgComic.alt = data.alt; | ||
| }) | ||
|
|
||
| .catch (error => { | ||
| console.error("Error fetching comic:", error); | ||
| alert("Could not load the comic. Please try again later."); | ||
| }); |
There was a problem hiding this comment.
-
Indentation is off.
-
Why not take this opportunity to practice using
asyncandawait(instead of chaining.then())?
There was a problem hiding this comment.
cjyuan
added
Reviewed
hibosharif202504
added
the
Needs Review
|
Changes look good! |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.