ZA | 25-ITP-May | Malusi Skunyana | Data Flows | Book Library #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubmit() call to addBook(), remove placeholder table row
…r() loop syntax, repair delete button event, correct read status logic, rename submit() to addBook(), clear form after add
MalusiS
added
the
Needs Review
MalusiS
changed the title
cjyuan
reviewed
Aug 11, 2025
There was a problem hiding this comment.
- Can you change the base branch of this PR from CYF's
book-libraryto CYF'smain?
- Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…ags of void elements
…numbers, add input validation, improve button naming, and fix delete confirmation timing
MalusiS
added
Needs Review
|
@cjyuan, I have changed the base branch to CYF's main. I have also made improvements to my code as per the general feedback you referred me to. Thank you so much for the great feedback. |
cjyuan
reviewed
Aug 11, 2025
Comment on lines
+23
to
+39
| titleInput.value.trim() === "" || | ||
| authorInput.value.trim() === "" || | ||
| pagesInput.value.trim() === "" | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| return; | ||
| } | ||
|
|
||
| if (!Number.isInteger(Number(pagesInput.value)) || Number(pagesInput.value) <= 0) { | ||
| alert("Pages must be a positive number."); | ||
| return; | ||
| } | ||
|
|
||
| let book = new Book( | ||
| titleInput.value.trim(), | ||
| authorInput.value.trim(), | ||
| Number(pagesInput.value), |
There was a problem hiding this comment.
For better performance (reduce number of function calls) and reducing the chance of using raw input accidently, we could stored the pre-processed/sanitized/normalized input in some variables first, and reference the variables in other part of the function.
There was a problem hiding this comment.
Thank you, CJ. I really appreciate the great feedback.
Comment on lines
+47
to
52
| function clearForm() { | ||
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| readCheckbox.checked = false; | ||
| } |
There was a problem hiding this comment.
If the input elements are enclosed inside a <form>, we could also clear them by calling the .reset() method of the form element.
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Summary
This PR fixes all known bugs in the Book Library project so it meets the specified requirements:
Changes by File
index.html:
script.js:
Questions
Ask any questions you have for your reviewer.