London| Emmanuel Gessessew | Module-Data-Groups | WEEK 3- Alarm clock #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emmanuelgessessew
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Jan 14, 2025
There was a problem hiding this comment.
-
Code works fine if a user only clicks the "Set Alarm" button once. However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly. Can you fix the problem?
-
You missed updating
index.htmlaccording to an instruction inreadme.md. -
Suggestion:
Instead of callingdocument.getElementById("timeRemaining")repeatedly to get the element, a better practice would be to store the selected element in a variable.
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
3
to
9
| let timeRemaining = Number(document.getElementById("alarmSet").value); | ||
|
|
||
|
|
||
| if (isNaN(timeRemaining) || timeRemaining <= 0) { | ||
| alert("Please enter a positive number!"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
- Some unusual input values that can make your app behave abnormally can still pass this check. Can you add code to sanitise this kind of values?
There was a problem hiding this comment.
i added the code accordingly.
cjyuan
added
Reviewed
Emmanuelgessessew
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.