CYF-ITP-South Africa | Evelyn Nomsa Mwanunura| Data Groups | Sprint 3 -Alarm Clock App #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvelynMwanunura
added
the
Needs Review
KudahShambare
suggested changes
Mar 8, 2025
There was a problem hiding this comment.
- Consider replacing the function syntax with arrow functions.
- Line 3 is a repetition of line 53
- stop alarm button is not stopping the timer
There was a problem hiding this comment.
Hi Kudah
I have implemented the suggestions, may you please review them.
Thank you.
There was a problem hiding this comment.
Hi Evelyn
- Your stop button is not yet pausing the clock ( you can have another event listener to control the timer since you are not allowed to edit the one provide)
- In your javascript file, please try to improve the way you structure your code, put variable declarations together, functions together, don't mix things
- https://stackoverflow.com/questions/30961607/how-do-i-add-two-different-event-listeners-to-one-button
KudahShambare
added
Reviewed
EvelynMwanunura
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear mentors and volunteers ,could you please review my PR? Thank you so much.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.