ITP|25|LONDON|LOVETH_OKAFOR|Module-Data-Groups|WEEK2_SPRINT_2 #320

loveth900 · 2025-03-04T09:55:40Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

cjyuan

There seem to be some mixed up in terms of which files should contain function definition and which files should contain test code. Can you move the function definitions to the proper files and implement the Jest test in the .test.js files?

cjyuan · 2025-03-11T19:36:54Z

Sprint-2/implement/contains.test.js

+function contains(obj, property) {
+    // Check that the input is an object, not an array.
+    if (typeof obj !== 'object' || obj === null || Array.isArray(obj)) {
+        return false;
+
+    }
+
+    // we need to verify if the specified property is present in the object.
+    return property in oby 
+}


Shouldn't this function be defined in contains.js?

Also, consider the following two approaches for determining if an object contains a property:

let obj = {}, propertyName = "toString"; console.log( propertyName in obj ); // true console.log( obj.hasOwnProperty(propertyName) ); // false

Which of these approaches suits your needs better?
For more info, you can look up JS "in" operator vs hasOwnProperty.

i have fixed it properly, thanks for the correction

cjyuan · 2025-03-11T19:44:37Z

Sprint-2/implement/contains.test.js

+    // we need to verify if the specified property is present in the object.
+    return property in oby 
+}
+


You were supposed to implement Jest test in this files according to the description in the comments.

hi dear mentor i have implemented as instructed.

cjyuan · 2025-03-11T19:46:55Z

Sprint-2/implement/lookup.js

+function createLookup(arr, key) {
+  const lookup = {}; 
+  // initialize an empty object to store the lookup table
+
+  // loop through each object in the input array.
+  Array.forEach(item => {
+  // assign the value of the specified key from the object as the lookup key.
+  // and store the  entire object as the corresponding value
+  lookup[item[key]] = item;
+
+  })
+
+  return lookup; 
+  // needed to return the completed lookup table.
+
 }


The function defined in lookup.test.js should replace this one.

alright, i have fixed the function.

cjyuan · 2025-03-11T19:47:55Z

Sprint-2/implement/lookup.test.js

+function createLookup(countryCurrencyPairs) {
+  const createLookup = {};
+  // create an empty object to hold the key-value pairs
+
+  // loop through each country-currency pair in the array
+  countryCurrencyPairs.forEach(pair => {
+    const [countryCode, currencyCode] = pair;
+  // Destructure each pair into countryCode and currencyCode
+  lookup[countryCode] = currencyCode;
+  // store the country code as the key and currency code as the value
+
+  });
+
+  return lookup; 
+
+  // return the constructed lookup object
+
+}
+


This function is correct but it should be defined in lookup.js.

You should only include Jest test code in this file.

cjyuan · 2025-03-11T19:56:30Z

Sprint-2/implement/querystring.test.js

+function parseQueryString(queryString) {
+  const params = {};
+
+  // split the query string by '&' to separate different key-value pairs
+  const pairs = queryString.split("&");
+
+  pairs.forEach(pair => {
+
+  // split each into key and value by the first '=' sign
+
+  const{key, value} = pair.split("=").map(decodeURIComponent);
+
+  // if there is more than one '=' symbol, join the rest of the value together
+  if (value && value.includes("=")) {
+    params[key] = pair.slice(key.length + 1);
+  // keep the value intact
+  } else {
+    params[key] = value || "";
+  }


This should be implemented in querystring.js.

For each of the following function calls, does your function return the value you expect?

parseQueryString("a=b&=&c=d") parseQueryString("a=") parseQueryString("=b") parseQueryString("a=b&&c=d") parseQueryString("a%25b=c%26d") parseQueryString("abc=x=y%26=z") parseQueryString("a%25b=x=y=z")

Note: the %25 and %26 are URL encoded or percent encoded characters.

cjyuan · 2025-03-11T20:03:10Z

Sprint-2/implement/tally.test.js

+test("tally throws an error when passed a string", () => {
+  expect(() => tally("invalid"))
+    .toThrow("Input must be an array");
+});


Does your function pass this test?

yes it's working now, thanks for letting me know.

cjyuan · 2025-03-11T20:04:40Z

Sprint-2/interpret/invert.js

+
 // a) What is the current return value when invert is called with { a : 1 }

 // b) What is the current return value when invert is called with { a: 1, b: 2 }


Why not answering these questions?

thanks dear mentor i have answered the question.

cjyuan · 2025-03-11T20:07:02Z

Sprint-2/interpret/invert.test.js

+test("", () => {
+  const obj = { x: 10, y: 20 };
+  const answer = invert(obj);
+  expect(answer).toEqual({ 10: "x", 20: "y" });
+});
+test("", () => {
+  const obj = { name: "Evelyn", Age: 35 };
+  const answer = invert(obj);
+  expect(answer).toEqual({ Evelyn: "name", 35: "Age" });
+});


What are these two tests trying to test?

well i think there are trying to test the the behavior of the invert function, which takes an object as input and swaps its keys and values.

cjyuan · 2025-03-11T20:17:35Z

Sprint-2/stretch/mode.js

-  return maxFreq === 0 ? NaN : mode;
+  return modeValue;


Do you know in what circumstance the value returned by this function is not the same as the value returned by the original function?

Yes i have an idea, the two return values are different when there is no mode in the dataset (i.e., when maxFreq === 0), because the first return statement returns NaN, whereas the second return statement could return an incorrect modeValue.

cjyuan · 2025-03-11T20:20:48Z

Sprint-2/stretch/mode.test.js

+  return mode;
+}
+
+module.exports = calculateMode;


This file should only contain Jest test code.

The definition of the function and module.exports = calculateMode; should be placed in mode.js instead.

Hi dear mentor @cjyuan have corrected the error i will appriciate if you check my work

loveth900 added 17 commits March 3, 2025 04:53

the data found

e35f5ef

the iterate loop

c7d193b

the recipe is decleard

6eb829d

the array fixed

cca7126

the contain value found

bccf5ce

the lookup found

545fdeb

the object were found

0d23ffc

the strings key

c4a787e

the value found

d3ed3b1

its tallyed

86cb1c4

done

a51b33e

the was set

51138bd

test defined

33841ca

the count

c70ac69

mode done

eddb197

mode test done

7cc7955

till gotten

7eb1d4d

loveth900 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2025

cjyuan reviewed Mar 11, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 12, 2025

loveth900 added 7 commits March 13, 2025 07:02

fixed the function

e8d5d96

done

27b0958

corrected

d731727

fixed

8ac4beb

i have corrected the issue

3ac3b0d

done

aa795c8

fixed

bc53def

loveth900 added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Mar 22, 2025


		// a) What is the current return value when invert is called with { a : 1 }

		// b) What is the current return value when invert is called with { a: 1, b: 2 }

Uh oh!

ITP|25|LONDON|LOVETH_OKAFOR|Module-Data-Groups|WEEK2_SPRINT_2 #320

Are you sure you want to change the base?

ITP|25|LONDON|LOVETH_OKAFOR|Module-Data-Groups|WEEK2_SPRINT_2 #320

Uh oh!

Conversation

loveth900 commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

loveth900 commented Mar 4, 2025 •

edited

Loading

cjyuan Mar 11, 2025 •

edited

Loading