Fixes for Sprint 1 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix up typos in exercises * Update a bunch of week-1s to Sprint-1s * Use toEqual not toBe * Add a bit more scaffolding for exports and requires, as we currently don't reliably teach this. * Add a few more edge cases to test for * Move root package.json to Sprint-3 directory, because that's the set of tests it hard-codes as modules, and rework instructions to not assume you're installing stuff in the root of the repo. * Change refactor exercises from implementing `find` to implementing `includes` - because `find` returns the index, I would consider it better implemented with a for-with-index loop than a for..of loop. `includes` does not share this property.
moneyinthesky
approved these changes
Oct 10, 2024
RihannaP
pushed a commit
to RihannaP/Module-Data-Groups
that referenced
this pull request
Jan 13, 2025
* Fix up typos in exercises * Update a bunch of week-1s to Sprint-1s * Use toEqual not toBe * Add a bit more scaffolding for exports and requires, as we currently don't reliably teach this. * Add a few more edge cases to test for * Move root package.json to Sprint-3 directory, because that's the set of tests it hard-codes as modules, and rework instructions to not assume you're installing stuff in the root of the repo. * Change refactor exercises from implementing `find` to implementing `includes` - because `find` returns the index, I would consider it better implemented with a for-with-index loop than a for..of loop. `includes` does not share this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findto implementingincludes- becausefindreturns the index, I would consider it better implemented with a for-with-index loop than a for..of loop.includesdoes not share this property.