Sheffield| May 2025| Mayowa Fadare|Module data sprint 2 #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayowa0-7
added
the
Needs Review
mayowa0-7
changed the title
cjyuan
reviewed
Jul 26, 2025
Sprint-2/implement/tally.js
Outdated
Comment on lines
2
to
14
| function tally(items) { | ||
| if (!Array.isArray(items)) { | ||
| throw new Error("Input must be an array"); | ||
| } | ||
| const counts = {}; | ||
| for (const item of items) { | ||
| if (typeof item !== "string" && typeof item !== "number") { | ||
| throw new Error("Items must be strings or numbers"); | ||
| } | ||
| counts[item] = (counts[item] || 0) + 1; | ||
| } | ||
| return counts; | ||
| } |
There was a problem hiding this comment.
-
Can you improve the indentation of this code?
-
Can you check if your function returns what you expect from the following function call?
tally(["toString", "toString", "toString"]);
There was a problem hiding this comment.
Thanks for the review, code now well indented and function call updated. ✅
cjyuan
added
Reviewed
mayowa0-7
added
Needs Review
cjyuan
reviewed
Aug 1, 2025
Sprint-2/implement/tally.js
Outdated
| @@ -1,16 +1,16 @@ | |||
|
|
|||
| function tally(items) { | |||
| function tally(["toString", "toString", "toString"]); { | |||
There was a problem hiding this comment.
Does this code even run? My previous comment was
Can you check if your function returns what you expect from the following function call?
tally(["toString", "toString", "toString"]);
There was a problem hiding this comment.
No it doesn't, but I have effected it with the correct function
cjyuan
added
Reviewed
mayowa0-7
added
Needs Review
cjyuan
reviewed
Aug 2, 2025
Sprint-2/implement/tally.js
Outdated
Comment on lines
6
to
12
| const counts = {}; | ||
| for (const item of items) { | ||
| if (typeof item !== "string" && typeof item !== "number") { | ||
| throw new Error("Items must be strings or numbers"); | ||
| } | ||
| counts[item] = (counts[item] || 0) + 1; | ||
| } |
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion: Look up an approach to create an empty object with no inherited properties.
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.