Skip to content

London | May-2025 | Ikenna Agulobi | Data Groups |Sprint-3 Alarm Clock #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

London | May-2025 | Ikenna Agulobi | Data Groups |Sprint-3 Alarm Clock #686

wants to merge 7 commits into from

Conversation

ike-agu
Copy link

@ike-agu ike-agu commented Jul 23, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
This PR includes my completed Alarm clock exercise for Sprint 3 - Data Groups module.

Questions

Ask any questions you have for your reviewer.

@ike-agu ike-agu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 23, 2025
@day-lee day-lee added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 28, 2025
@day-lee day-lee self-requested a review July 28, 2025 19:33
day-lee
day-lee reviewed Jul 28, 2025
View reviewed changes
Sprint-3/alarmclock/alarmclock.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ikenna, code looks good and it works as intended. For a better user experience, it would be nicer if the background colour change back to white once Stop alarm is clicked. Can you implement this code? If you want to complete the task from here, it's totally fine too. Let me know!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @day-lee, I've implemented the change request. Could you take a look when you are available. Thank you!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review and feedback!

@ike-agu ike-agu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2025
@day-lee day-lee added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 29, 2025
@ike-agu ike-agu mentioned this pull request Jul 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@day-lee day-lee day-lee left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ike-agu @day-lee @illicitonion