This repository was archived by the owner on Apr 18, 2025. It is now read-only.
NW6 | Haythem Mohammed | Module-JS1 | WEEK3 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well done |
bunday
suggested changes
Dec 9, 2023
| @@ -21,3 +21,17 @@ | |||
| // Identify Reflex Angles: | |||
| // When the angle is greater than 180 degrees and less than 360 degrees, | |||
| // Then the function should return "Reflex angle" | |||
|
|
|||
| function getAngleType(angle) { | |||
There was a problem hiding this comment.
thank for you your feedback I will fix it
| @@ -33,3 +33,11 @@ | |||
| // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false. | |||
|
|
|||
| // These acceptance criteria cover a range of scenarios to ensure that the isProperFraction function handles both proper and improper fractions correctly and handles potential errors such as a zero denominator. | |||
|
|
|||
| function isProperFraction(Numerator,Denominator) { | |||
There was a problem hiding this comment.
you didnt check if the denominator is 0. your variable names should start with a small letter. i.e numerator
| @@ -4,3 +4,55 @@ | |||
| // Store this expression in a variable and reference it twice in the function in the correct place | |||
|
|
|||
| // Explain why it makes more sense to store this expression in a variable | |||
|
|
|||
| function formatAs12HourClock(time) { | |||
| if (Number(time.slice(0, 2)) > 12) { | |||
There was a problem hiding this comment.
this is a bit complicated, can you think of a simpler solution where you can get the hours, and check if its less than 12 or not, to decide the am or pm and also use that to get the right time
There was a problem hiding this comment.
okay, thank you for checking my work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.