This repository was archived by the owner on Apr 18, 2025. It is now read-only.
NW-6 | Fikret Ellek | JS3| [TECH ED] Programmer Humour | WEEK-3 #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
musayuksel
reviewed
Feb 23, 2024
| const myDate = document.createElement("p"); | ||
| myDate.id = "date"; | ||
| myDate.innerText = `${data.day}/${data.month}/${data.year}`; | ||
|
|
There was a problem hiding this comment.
You have used semantic HTML elements well here, great work!
|
|
||
| const myImg = document.createElement("img"); | ||
| myImg.setAttribute("src", data.img); | ||
| myImg.setAttribute("alt", data.safe_title); |
Comment on lines
+22
to
+24
| myCont.append(myTitle, myDate, myImg, mySummary); | ||
|
|
||
| document.body.append(myCont); |
There was a problem hiding this comment.
It is very clean, very readable, and also shows the correct use of the order of the append Well done @fikretellek !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.