ITP JAN-25-London | MIKIYAS GEBREMICHAEL | STRUCTURING AND TESTING DATA | SPRINT-3 | WEEK - 3

Sprint-3/1-key-implement/1-get-angle-type.js

@@ -10,6 +10,10 @@
 function getAngleType(angle) {
    if (angle === 90) return "Right angle";
    // read to the end, complete line 36, then pass your test here
+   else if (angle<90) return "Acute angle"
+   else if (angle>90 && angle<180) return "Obtuse angle"
+   else if (angle === 180) return "Straight angle";
+   else if (angle>180) return "Reflex angle";
 }
 
 // we're going to use this helper function to make our assertions easier to read
@@ -44,13 +48,18 @@ assertEquals(acute, "Acute angle");
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse,"Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
+const straight =getAngleType(180);
+assertEquals(straight,"Straight angle")
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(220);
+assertEquals(reflex,"Reflex angle");

Sprint-3/1-key-implement/2-is-proper-fraction.js

@@ -6,48 +6,41 @@
 // the first test and first case is written for you
 // complete the rest of the tests and cases
 // write one test at a time, and make it pass, build your solution up methodically
+/*
+I fixed this code below ,with a better version of it.
+function isProperFraction(numerator, denominator) {
+  if (numerator < denominator) return true;
+  else if (numerator > denominator) return false; // Improper Fraction check
+  else if (numerator < 0 && denominator > numerator)
+    return true; // Negative Fraction check
+  else if (numerator === denominator) return false; //equalFraction
+  //down here are part of the Stretch goals
+  else if (numerator === 0) return true; //Proper fraction
+  else if (denominator === 0) return false; //Invalid input
+  else if (numerator < 0 && denominator < 0 && numerator > denominator)
+    return true; //Negative cancellation
+}*/
 
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+    if (denominator === 0) return false; //Invalid fraction(division by zero)
+    if (Math.abs(numerator) < Math.abs(denominator)) return true; //Proper fraction check
+    return false; // Otherwise, it's an improper fraction
 }
 
-// here's our helper again
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
     `Expected ${actualOutput} to equal ${targetOutput}`
   );
 }
 
-// Acceptance criteria:
-
-// Proper Fraction check:
-// Input: numerator = 2, denominator = 3
-// target output: true
-// Explanation: The fraction 2/3 is a proper fraction, where the numerator is less than the denominator. The function should return true.
-const properFraction = isProperFraction(2, 3);
-assertEquals(properFraction, true);
-
-// Improper Fraction check:
-// Input: numerator = 5, denominator = 2
-// target output: false
-// Explanation: The fraction 5/2 is an improper fraction, where the numerator is greater than or equal to the denominator. The function should return false.
-const improperFraction = isProperFraction(5, 2);
-assertEquals(improperFraction, false);
-
-// Negative Fraction check:
-// Input: numerator = -4, denominator = 7
-// target output: true
-// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
-const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
-
-// Equal Numerator and Denominator check:
-// Input: numerator = 3, denominator = 3
-// target output: false
-// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
-const equalFraction = isProperFraction(3, 3);
-// ====> complete with your assertion
-
-// Stretch:
-// What other scenarios could you test for?
+//Test Cases
+assertEquals(isProperFraction(2, 3), true); //proper fraction
+assertEquals(isProperFraction(5, 2), false);//improper Fraction
+assertEquals(isProperFraction(-4, 7), true);// negative Proper Fraction
+assertEquals(isProperFraction(3, 3), false);// equal Numerator and Denominator
+assertEquals(isProperFraction(0, 3), true);// numerator is 0
+assertEquals(isProperFraction(1, 0), false);// denominator is 0
+assertEquals(isProperFraction(-2, -4), true);// both Numerator and Denominator are negative
+assertEquals(isProperFraction(-5, 3), false);// improper Negative Fraction
+assertEquals(isProperFraction(-7, 2), false);// numerator larger but negative

Sprint-3/1-key-implement/3-get-card-value.js

@@ -8,7 +8,12 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+    let rank = card.slice(0, -1);
     if (rank === "A") return 11;
+    else if (rank>="2" && rank<="9") return Number(rank);
+    else if (rank==="10" || rank==="J" || rank==="Q" || rank==="K") return 10;
+    else return "Invalid card rank";
+
 }
 
 // You need to write assertions for your function to check it works in different cases
@@ -25,21 +30,22 @@ function assertEquals(actualOutput, targetOutput) {
 // Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
-const aceofSpades = getCardValue("A♠");
-assertEquals(aceofSpades, 11);
+const aceOfSpades = getCardValue("A♠");
+assertEquals(aceOfSpades, 11);
 
 // Handle Number Cards (2-10):
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
-const fiveofHearts = getCardValue("5♥");
+const fiveOfHearts = getCardValue("5♥");
 // ====> write your test here, and then add a line to pass the test in the function above
-
+assertEquals(fiveOfHearts, 5);
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
-
+const blackJack = getCardValue("10")
+assertEquals(blackJack, 10);
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
@@ -49,3 +55,6 @@ const fiveofHearts = getCardValue("5♥");
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+const invalidSampleForTest = getCardValue("22");
+assertEquals(invalidSampleForTest, "Invalid card rank.")
+

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

@@ -1,7 +1,10 @@
 function getAngleType(angle) {
   if (angle === 90) return "Right angle";
   // replace with your completed function from key-implement
-
+   else if (angle<90) return "Acute angle"
+   else if (angle>90 && angle<180) return "Obtuse angle"
+   else if (angle === 180) return "Straight angle";
+   else if (angle>180) return "Reflex angle";
 }
 
 

Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js

@@ -4,21 +4,23 @@ test("should identify right angle (90°)", () => {
   expect(getAngleType(90)).toEqual("Right angle");
 });
 
-// REPLACE the comments with the tests
-// make your test descriptions as clear and readable as possible
 
-// Case 2: Identify Acute Angles:
-// When the angle is less than 90 degrees,
-// Then the function should return "Acute angle"
+test("this test should identify any Acute Angles (less than 90°)", () => {
+  expect(getAngleType(75)).toEqual("Acute angle");
+});
+
+
+test("this test should identify any obtuse Angles (angles between 90 and 180 degrees)", () => {
+  expect(getAngleType(125)).toEqual("Obtuse angle");
+});
+
+
+test("should identify any Straight angles(180 degrees)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 
-// Case 3: Identify Obtuse Angles:
-// When the angle is greater than 90 degrees and less than 180 degrees,
-// Then the function should return "Obtuse angle"
 
-// Case 4: Identify Straight Angles:
-// When the angle is exactly 180 degrees,
-// Then the function should return "Straight angle"
 
-// Case 5: Identify Reflex Angles:
-// When the angle is greater than 180 degrees and less than 360 degrees,
-// Then the function should return "Reflex angle"
+test("this test should identify any Reflex Angles (angles between 180 and 360 degrees)", () => {
+  expect(getAngleType(200)).toEqual("Reflex angle");
+});

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

@@ -1,6 +1,13 @@
 function isProperFraction(numerator, denominator) {
     if (numerator < denominator) return true;
     // add your completed function from key-implement here
+    else if (numerator > denominator) return false; // Improper Fraction check
+    else if (numerator<0 && denominator>numerator) return true;// Negative Fraction check
+    else if (numerator===denominator) return false;//equalFraction
+    //down here are part of the Stretch goals
+    else if (numerator === 0 ) return true; //Proper fraction
+    else if (denominator === 0) return false; //Invalid input
+    else if (numerator < 0 && denominator < 0 && numerator > denominator) return true; //Negative cancellation
 }
 
 module.exports = isProperFraction;

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

@@ -5,7 +5,16 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an Improper fraction", () => {
+  expect(isProperFraction(3, 2)).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return true for Negative Fraction", () => {
+  expect(isProperFraction(-2, 3)).toEqual(true);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false for a Fraction with equal numerator and denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+});

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -1,5 +1,8 @@
 function getCardValue(card) {
-    // replace with your code from key-implement
-    return 11;
+    let rank = card.slice(0, -1);
+    if (rank === "A") return 11;
+    else if (rank>="2" && rank<="9") return Number(rank);
+    else if (rank==="10" || rank==="J" || rank==="Q" || rank==="K") return 10;
+    else return "Invalid card rank";
 }
 module.exports = getCardValue;

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

@@ -1,11 +1,27 @@
 const getCardValue = require("./3-get-card-value");
 
 test("should return 11 for Ace of Spades", () => {
-    const aceofSpades = getCardValue("A♠");
-    expect(aceofSpades).toEqual(11);
+    const aceOfSpades = getCardValue("A♠");
+    expect(aceOfSpades).toEqual(11);
     });
 
 // Case 2: Handle Number Cards (2-10):
+test("should return 5 for 5 of Spades", () => {
+    const aceOfSpades = getCardValue("5♠");
+    expect(aceOfSpades).toEqual(5);
+    });
 // Case 3: Handle Face Cards (J, Q, K):
+test("should return 10 for Q of Spades", () => {
+    const aceOfSpades = getCardValue("Q♠");
+    expect(aceOfSpades).toEqual(10);
+    });
 // Case 4: Handle Ace (A):
+test("should return 11 for Ace of Spades", () => {
+    const aceOfSpades = getCardValue("A♠");
+    expect(aceOfSpades).toEqual(11);
+    });
 // Case 5: Handle Invalid Cards:
+test("should return Invalid card rank for Invalid Inputs", () => {
+    const aceOfSpades = getCardValue("M♠");
+    expect(aceOfSpades).toEqual("Invalid card rank");
+    });

Sprint-3/3-mandatory-practice/implement/count.js

@@ -1,5 +1,6 @@
 function countChar(stringOfCharacters, findCharacter) {
-    return 5
+    let splitArr = stringOfCharacters.split(findCharacter);
+    return splitArr.length-1;
 }
 
 module.exports = countChar;

Sprint-3/3-mandatory-practice/implement/count.test.js

@@ -22,3 +22,10 @@ test("should count multiple occurrences of a character", () => {
 // And a character char that does not exist within the case-sensitive str,
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+
+test("should count multiple occurrences of a character", () => {
+  const str = "abcdefghjkl";
+  const char = "z";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

@@ -1,5 +1,9 @@
 function getOrdinalNumber(num) {
- return "1st";
+    if(num ===1 ) return "1st";
+    else if(num === 2 ) return "2nd";
+    else if(num === 3 ) return "3rd";
+    else return num + "th";
+
 }
 
-module.exports = getOrdinalNumber;
+module.exports = getOrdinalNumber;

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

@@ -7,7 +7,15 @@ const getOrdinalNumber = require("./get-ordinal-number");
 // Case 1: Identify the ordinal number for 1
 // When the number is 1,
 // Then the function should return "1st"
-
 test("should return '1st' for 1", () => {
     expect(getOrdinalNumber(1)).toEqual("1st");
     });
+test("should return '2nd' for 2", () => {
+    expect(getOrdinalNumber(2)).toEqual("2nd");
+});
+test("should return '3rd' for 3", () => {
+    expect(getOrdinalNumber(3)).toEqual("3rd");
+});
+test("should return '4th' for 4", () => {
+    expect(getOrdinalNumber(4)).toEqual("4th");
+});

Sprint-3/3-mandatory-practice/implement/repeat.js

@@ -1,5 +1,15 @@
-function repeat() {
-    return "hellohellohello";
+function repeat(strToRepeat, howMuchRep) {
+    if (!Number.isInteger(howMuchRep)) {
+        return "Float values are invalid";
+    }
+    if (howMuchRep < 0) {
+        return "Negative Counts are not valid";
+    }
+    return strToRepeat.repeat(howMuchRep);
 }
 
-module.exports = repeat;
+module.exports = repeat;
+
+
+
+module.exports = repeat;

Sprint-3/3-mandatory-practice/implement/repeat.test.js

@@ -20,13 +20,37 @@ test("should repeat the string count times", () => {
 // Given a target string str and a count equal to 1,
 // When the repeat function is called with these inputs,
 // Then it should return the original str without repetition, ensuring that a count of 1 results in no repetition.
+test("should repeat the string count times", () => {
+    const str = "hello";
+    const count = 1;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("hello");
+    });
 
 // case: Handle Count of 0:
 // Given a target string str and a count equal to 0,
 // When the repeat function is called with these inputs,
 // Then it should return an empty string, ensuring that a count of 0 results in an empty output.
+test("should repeat the string 0 times", () => {
+    const str = "hello";
+    const count = 0;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("");
+    });
 
 // case: Negative Count:
 // Given a target string str and a negative integer count,
 // When the repeat function is called with these inputs,
 // Then it should throw an error or return an appropriate error message, as negative counts are not valid.
+test("should repeat the string count times", () => {
+    const str = "hello";
+    const count = -3;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("Negative Counts are not valid");
+    });
+test("should repeat the string count times", () => {
+    const str = "hello";
+    const count = 2.5;
+    const repeatedStr = repeat(str, count);
+    expect(repeatedStr).toEqual("Negative Counts are not valid");
+    });