WM | May-2025 | Abdullah Saleh | Sprint-2 #554
Conversation
…'num' to the function
LonMcGregor
added
Review in progress
| squaredHeight = height * height; | ||
| BodyMassIndex = (weight / squaredHeight).toFixed(1); |
There was a problem hiding this comment.
Remember to follow the normal guidelines for declaring variables - anything you would change when declaring BodyMassIndex?
There was a problem hiding this comment.
Thank you for your feedback, yes, I supposed to use const to declare the variables. I made the changes and committed it.
| } | ||
| toPounds((penceString = "399p")); | ||
| toPounds((penceString = "102p")); | ||
| toPounds((penceString = "1025p")); |
There was a problem hiding this comment.
What effect does passing in (penceString = "399p") have here? Could you simplify these function calls?
There was a problem hiding this comment.
Thank you for your feedback.
You're right — the assignment inside the function call was unnecessary and could be confusing. I've now simplified the function calls by removing the assignment and just passing the string literals directly to toPounds().
LonMcGregor
added
Reviewed
|
Good fixes for your answers. You are now complete with sprint 2. Well done! |
LonMcGregor
added
Complete
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.