London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Coursework/sprint 2 #700
Conversation
…dle, and last names.
…om file path string using slice.
…ween minimum and maximum.
Moved padStart(2, "0") to a single location after calculating rawHour. Improves readability and makes the function easier to maintain. Thanks for the helpful suggestion!
HoussamLh
added
the
Needs Review
LonMcGregor
added
the
Review in progress
There was a problem hiding this comment.
Good start on this sprint's tasks, You have solved all of these tasks well. I have spotted a few areas where you could improve code further.
Regarding your question about titles in the PR - I'm not sure I understand what you are asking. If you mean the title format, follow the instructions in any errors that get notified. If there are no notes, it is formatted correctly.
Sprint-2/1-key-errors/0.js
Outdated
| // =============> write your new code here | ||
| // =============> write your new code here | ||
| function capitalise(str) { | ||
| let capitalisedStr = `${str[0].toUpperCase()}${str.slice(1)}`; |
There was a problem hiding this comment.
Renaming the variable allows you to fix the bug, great!
The pattern here is you are defining a variable and then immediately returning it. Can you think how to make this code even simpler?
There was a problem hiding this comment.
Hi LonMcGregor,
Thank you for your feedback.
I see what you mean — I don’t actually need the extra variable here.
I can simplify it by returning the string directly, Like this :
function capitalise(str) {
return ${str[0].toUpperCase()}${str.slice(1)};
}
because this way the function is shorter and still clear.
Sprint-2/1-key-errors/1.js
Outdated
|
|
||
| function convertToPercentage(decimalNumber) { | ||
| const percentage = `${decimalNumber * 100}%`; | ||
| return percentage; |
There was a problem hiding this comment.
I have the same comment as in task 0 - this works, but could be simplified further
There was a problem hiding this comment.
Hi LonMcGregor,
Thank you! I see your point — the extra variable isn’t needed here either. I can simplify it by returning the result directly, like:
function convertToPercentage(decimalNumber) {
return ${decimalNumber * 100}%;
}
This makes it cleaner while keeping the same functionality.
LonMcGregor
added
Reviewed
HoussamLh
added
Needs Review
Self checklist
Changelist
Questions