Skip to content

Conversation

shreefAhmedM
Copy link

@shreefAhmedM shreefAhmedM commented Sep 15, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Her is JavaScript tasks covering exercises, error fixing, code interpretation, and a stretch exploration activity.

Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

4 similar comments
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

@shreefAhmedM shreefAhmedM changed the title Glasgow | 25-ITP-SEP |Shreef Ibrahim | Sprint 1 | coursework/sprint-1 Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 1 | Coursework Sep 15, 2025
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

2 similar comments
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

@shreefAhmedM shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 15, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 17, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted one areas where you could improve code further, and another has a note about language which may be useful

console.log(num)
//num is a random number between the minimum and maximum.
// 1. Math.random() static method returns a floating-point, pseudo-random number that's greater than or equal to 0 and less than 1
// 2. (maximum - minimum + 1) Calculates the range of values, including both ends.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When describing situations like this, instead of "including both ends" or something, I would suggest using a word like "inclusive" or "exclusive". Good explanation, though!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks

// console.log(last4Digits) => TypeError: cardNumber.slice is not a function at Object.
const cardNumber = 4533787178994213;
// const last4Digits = cardNumber.toString;
const last4Digits = cardNumber % 10000;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creative solution! Would this still function properly if the card number was 4533787178900003?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank i have updated this one

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 17, 2025
@shreefAhmedM shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants