-
-
Notifications
You must be signed in to change notification settings - Fork 200
Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 1 | Coursework #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 1 | Coursework #704
Conversation
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
4 similar comments
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
2 similar comments
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this sprint's tasks, I have spotted one areas where you could improve code further, and another has a note about language which may be useful
console.log(num) | ||
//num is a random number between the minimum and maximum. | ||
// 1. Math.random() static method returns a floating-point, pseudo-random number that's greater than or equal to 0 and less than 1 | ||
// 2. (maximum - minimum + 1) Calculates the range of values, including both ends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When describing situations like this, instead of "including both ends" or something, I would suggest using a word like "inclusive" or "exclusive". Good explanation, though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks
Sprint-1/2-mandatory-errors/3.js
Outdated
// console.log(last4Digits) => TypeError: cardNumber.slice is not a function at Object. | ||
const cardNumber = 4533787178994213; | ||
// const last4Digits = cardNumber.toString; | ||
const last4Digits = cardNumber % 10000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creative solution! Would this still function properly if the card number was 4533787178900003?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank i have updated this one
Self checklist
Her is JavaScript tasks covering exercises, error fixing, code interpretation, and a stretch exploration activity.