Skip to content

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-implement-and-rewrite #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-implement-and-rewrite #709

wants to merge 21 commits into from

Conversation

TzeMingHo
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

For the 3 exercises, I have created assert conditions and tests for each case, as well as some stretch cases.

@TzeMingHo
npm installed
9d43b8b
@TzeMingHo
In 1 key-errors, made a preditions, explained the syntax error, and f…
150a780 
…ixed the conflict with a new variable name
@TzeMingHo
In 1-key-errors, deleted unwanted variable, and console.log function …
8fdb210 
…with parameter
@TzeMingHo
In 1-key-errors/2.js, replacing 3 with num as parameter
24f2d3c
@TzeMingHo
In 2-mandatory-debug/0.js, updated return in the function
96ebf89
@TzeMingHo
In 2-mandatory-debug/1.js, updated return inline with a+b
b2f87c5
@TzeMingHo
In 2-mandatory-debug/2.js, adding a parameter in the function
b73f73f
@TzeMingHo
In 3-mandatory-implement/1-bmi.js, filled in the function to get bmi …
72112ca 
…to 1 decimal
@TzeMingHo
In 3-mandatory-implement/2-cases.js, created a function to convert lo…
a505558 
…wer case to upper case and replace all space with underline
@TzeMingHo
In 3-mandatory-implement/3-to-pounds.js, created a reusable function …
6c1636f 
…toPounds with input condition checks
@TzeMingHo
In 4-mandatory-interpret/time-format.js, filled in answers
401db2b
@TzeMingHo
In 5-stretch-extend/format-time.js, tried edge cases and invalid inputs
5733d12
@TzeMingHo
correcting padStart for minutes String
096632e
@TzeMingHo
Remove package-lock.json from pull request
b0fe035
@TzeMingHo
ignore package-lock.json
7a2b0a1
@TzeMingHo
adding 5 tests and passing 5 tests for 1-get-angle-type
096f9b6
@TzeMingHo
finsihed 4 cases and tests of proper fraction, start doing stretch cases
5245e20
@TzeMingHo
adding 9 stretch tests in proper fraction
bc00dfc
@TzeMingHo
adding tests for card values in blackjack
bc1b331
@TzeMingHo
restore sprint-2 from origin/main
51eedee
@TzeMingHo
restore gitignore from origin/main
6c04424
@TzeMingHo TzeMingHo added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 23, 2025
@jenny-alexander jenny-alexander self-requested a review October 4, 2025 13:55
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenny-alexander jenny-alexander Awaiting requested review from jenny-alexander

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TzeMingHo @jenny-alexander