London|ITP-25-September|Alexandru Pocovnicu|Sprint 1| Coursework #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

alexandru-pocovnicu wants to merge 14 commits into CodeYourFuture:main from alexandru-pocovnicu:coursework/sprint-1

alexandru-pocovnicu commented Sep 29, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed Sprint 1 exercises in which i added comments, fixed errors,and interpreted code

Questions

In 1-key-exercises - 4-random.js I understand the methods but don't understand why this " (maximum - minimum + 1)) + minimum " is necessary s

alexandru-pocovnicu added 14 commits

September 28, 2025 17:50


          explained what line 3 is doing

d543994


          extracted initials

a7cc13e


          assigned values to dir and ext

cb1e645


          described what each method does and the order each expression is eval…

2d115ce

…uated


          added"//" so that the instructions don't get executed

f6b6842


          explained why we can't reassign a variable when using "const"

a4b365b


          a variable needs to be declared before being initialized

f8be9ec


          updated the code by turning the value of cardNumber in to a string

6631cd9


          updated the names of the variables so that they dont't start with num…

357720b

…bers


          answerred the questions and added a ","

f6c81bf


          added explanations for variable declarations, function calls, and exp…

54c1b63

…ressions in comments


          commented what each line of code does

62b453f


          add explanations for the effects of the prompt function and its ret…

…urn value


          add explanations for the output of console and the syntax of `conso…

2cb91c3

…le.log`

alexandru-pocovnicu added the Needs Review label

github-actions bot commented Sep 29, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

5 similar comments

github-actions bot commented Sep 29, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions bot commented Sep 29, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions bot commented Sep 29, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions bot commented Sep 29, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions bot commented Sep 29, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

alexandru-pocovnicu changed the title ~~London|ITP-25-September|Alexandru Pocovnicu|Sprint 1 Coursework~~ London|ITP-25-September|Alexandru Pocovnicu|Sprint 1| Coursework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels