Glasgow | 25-SDC-July | Sheetal Kharab | Sprint 4 | implement-shell tools in python #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkharab
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 19, 2025
| # set argument parser | ||
| parser = argparse.ArgumentParser(description="Python implementation of cat command") | ||
|
|
||
| # to number all lines |
There was a problem hiding this comment.
If these comments were not here, would it be obvious what these lines of code were doing?
There was a problem hiding this comment.
What is the purpose of the -1 argument here? Can you see any issues regarding your implementation with -1?
There was a problem hiding this comment.
There are a couple of issues here:
- Think about all the combinations of arguments a user might use - do you spot any issues?
- In your code there seems to be some duplication. Can you find where it is and develop a solution?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
code for ls, wc, cat
Questions
Ask any questions you have for your reviewer.