London-SDC | Ameneh Keshavarz | Module-Tools | Sprint1 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameneh-Keshavarz
added
the
Needs Review
ehwus
reviewed
Mar 16, 2025
| @@ -4,3 +4,5 @@ set -euo pipefail | |||
|
|
|||
| # TODO: Write a command to output just the names of each player in `scores-table.txt`. | |||
There was a problem hiding this comment.
nitpick: Consider removing TODO comments once their feature is implemented, you could replace the comment with an explanation about how your solution works (keeping the expected output as well)
| @@ -5,3 +5,5 @@ set -euo pipefail | |||
| # TODO: Write a command to output just the names of each player along with the number of times they've played the game. | |||
| # Your output should contain 6 lines, each with one word and one number on it. | |||
| # The first line should be "Ahmed 3". | |||
|
|
|||
| awk '{ print $1, NF-2 }' scores-table.txt | |||
There was a problem hiding this comment.
praise: Really great to see you hit these strech goals here 💪
| @@ -13,3 +13,5 @@ set -euo pipefail | |||
| # 3 It looked delicious. | |||
| # 4 I was tempted to take a bite of it. | |||
| # 5 But this seemed like a bad idea... | |||
|
|
|||
| cat -n ../helper-files/* | |||
| @@ -6,3 +6,5 @@ set -euo pipefail | |||
| # If a line starts with a number and a space, make the line instead end with a space and the number. | |||
| # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37". | |||
| # The output should contain 11 lines. | |||
|
|
|||
| sed 's/^\([0-9]\+\) \(.*\)$/\2 \1/' input.txt | |||
ehwus
added
Reviewed
Ameneh-Keshavarz
added
the
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.