Skip to content

Conversation

Mikiyas-STP
Copy link

@Mikiyas-STP Mikiyas-STP commented Jul 11, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Mikiyas-STP Mikiyas-STP added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 11, 2025
@chinar-amrutkar chinar-amrutkar self-assigned this Jul 16, 2025
@Mikiyas-STP Mikiyas-STP changed the title JULY-SDC | MIKIYAS GEBREMICHAEL | Module-Tools | Number System | Sprint-1 | WEEK-1 London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Number System Jul 18, 2025
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please review the comments I have added :)


How can you test if a binary number is a power of two (e.g. 1, 2, 4, 8, 16, ...)?
Answer:
Answer: if the digit at the last index is 1 and all others are 0 it is power of two (except 1 which is 01)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify what you mean by the "last index"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @chinar-amrutkar Thankyou for your feedbacks, i tried to include the explanation next to my answer by saying Clarification as Requested by Volunteer. Sorry there was a huge gap on my use of english and hopefully i explained it now.


If reading the bytes 0xAA00FF as an RGB colour, as described in "Approaches for Representing Colors and Images", what colour would it mean?
Answer:
Answer: AA =170, 00 = 0, FF = 255 It is RGB(170,000,255)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would the colour look like? Example answers - orange, black, etc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankyou, i have figured it out a color with 170 red and full blue is magneta purple.

@chinar-amrutkar chinar-amrutkar added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 22, 2025
@Mikiyas-STP
Copy link
Author

Hi @chinar-amrutkar I have answered my exercises and pushed my commits now.
Thankyou
let me know if this PR needs to be closed

@Mikiyas-STP
Copy link
Author

@LonMcGregor could you review this PR please? I have done the final adjustments as commented Thanks

@LonMcGregor
Copy link

Great - those clarifications look good. Apologies for the delay in reviewing. You can close this PR now.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants