This repository was archived by the owner on Dec 3, 2019. It is now read-only.
tic tac file updated #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://rawgit.com/sentayhuJo/javascript-module2/ticTacBranch/tictactoe-game/index.html I modified the code , i think its bug free, check it out and give me comment , Thanks |
drainpip
reviewed
Dec 12, 2016
| flag=1; | ||
| markWinner(diagonal2ClassName,flag); | ||
| return diagonals2[0] + ' is the winner.'; | ||
| }else if (moves>8) |
There was a problem hiding this comment.
You should do this check first, along with moves < 5 so you don't run the logic above unnecessarily.
| *Style the matching line to RED | ||
| *@return {<string>} | ||
| */ | ||
| for(var row=0;row<3;row++){ |
There was a problem hiding this comment.
I'm not sure if you guys are allowed to use Array.map() or Array.filter() for this assignment, but they would both make this markup much more easy to follow. Even if you can't use them, you should rewrite this with them and see what you come up with.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rawgit.com/sentayhuJo/javascript-module2/ticTacBranch/tictactoe-game/index.html
Waiting for comment .... Thanks