This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Grid color branch #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Short and simple. Would be great if you could share your code with the class on Sunday and explain to them what you did. |
drainpip
reviewed
Dec 12, 2016
| square.innerHTML = 'O'; | ||
| player = 1; | ||
| } | ||
|
|
||
| var result = checkGameOver(); | ||
| var result = winner(); | ||
|
|
||
| if( result!==false ) { |
There was a problem hiding this comment.
It's good to be exact, but you could also do if (!result) {...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello David's, I have completed this assignment. i used Javascript and css to complete the assignment.
Note : i will try re code this assignment using Vanilla javascript.
Waiting for Comment