-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiP] Raft Integrations #1976
[WiP] Raft Integrations #1976
Conversation
Bundle Size Diff
|
Plugin build for 2a1a87e is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 194.4, firstPaint: 574.85, domContentLoaded: 1705.05, loaded: 1707.05, firstContentfulPaint: 10664.4, firstBlock: 12738.15, type: 45.91, minType: 43.48, maxType: 48.59, typeContainer: 13.89, minTypeContainer: 11.91, maxTypeContainer: 18.82, focus: 65.67, minFocus: 52.21, maxFocus: 78.52, inserterOpen: 25.94, minInserterOpen: 23.25, maxInserterOpen: 30.12, inserterSearch: 8.69, minInserterSearch: 7.58, maxInserterSearch: 11.11, inserterHover: 41.49, minInserterHover: 37.61, maxInserterHover: 49.32, listViewOpen: 154.73, minListViewOpen: 146.26, maxListViewOpen: 171.17 |
added a read-more link to the docs
@HardeepAsrani Need your help with this if possible. I have tweaked the title and description in the last commit, and I added a learn more text link, that is linking the user to this url: https://docs.themeisle.com/article/1975-fse-onboarding However, I am not sure if I got the html right, can you please take a look and fix it if needed? |
@JohnPixle I've fixed that. |
fixed line heights of title and description
updated text in final step
fixed typo
Looking good, I just made some final tweaks at the finish page. Now as I understand it is hidden with What you think @HardeepAsrani ? |
@HardeepAsrani Tested and everything's fine on my end regarding the onboarding 🚀 |
Removed FSE reference from copy
changed copy in the onboarding toggle.
@HardeepAsrani Good morning, I just tested these, thanks for the update. For the checkbox part, if it is un-checked can we hide the field as we had discussed? Let me know if you need help with that or any clarifications! For the wonky behaviour of the wizard, I have not seen any change, or it might have been un-noticeable. It might have performed a bit faster, but the re-rendering still took place. Thanks! PS: just made two slight copy changes at the start and finish screens, they are ok. |
Changed start screen copy
changed button copy at final screen
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #.
Summary
This adds Onboarding to Raft that works alongside this PR: Codeinwp/raft#85
It should redirect you automatically for the first time, and later on you can use the Onboarding link in Appearance Menu.
Test instructions
Checklist before the final review