Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] Raft Integrations #1976

Merged
merged 40 commits into from
Dec 18, 2023
Merged

[WiP] Raft Integrations #1976

merged 40 commits into from
Dec 18, 2023

Conversation

HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Nov 22, 2023

Closes #.

Summary

This adds Onboarding to Raft that works alongside this PR: Codeinwp/raft#85

It should redirect you automatically for the first time, and later on you can use the Onboarding link in Appearance Menu.

Test instructions

  • Make sure Onboarding works smoothly and everything is imported as expected.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@HardeepAsrani HardeepAsrani changed the base branch from development to next November 22, 2023 04:15
@HardeepAsrani HardeepAsrani marked this pull request as ready for review November 30, 2023 09:56
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 30, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 284.71 KB 284.71 KB 0 B (0.00%)
Blocks 1.5 MB 1.5 MB 0 B (0.00%)
CSS 91.71 KB 91.71 KB 0 B (0.00%)
Dashboard 348.59 KB 349.13 KB 553 B (0.15%)
Export Import 89.53 KB 89.53 KB 0 B (0.00%)
Pro 354.15 KB 354.15 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 30, 2023

Plugin build for 2a1a87e is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 30, 2023

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 194.4, firstPaint: 574.85, domContentLoaded: 1705.05, loaded: 1707.05, firstContentfulPaint: 10664.4, firstBlock: 12738.15, type: 45.91, minType: 43.48, maxType: 48.59, typeContainer: 13.89, minTypeContainer: 11.91, maxTypeContainer: 18.82, focus: 65.67, minFocus: 52.21, maxFocus: 78.52, inserterOpen: 25.94, minInserterOpen: 23.25, maxInserterOpen: 30.12, inserterSearch: 8.69, minInserterSearch: 7.58, maxInserterSearch: 11.11, inserterHover: 41.49, minInserterHover: 37.61, maxInserterHover: 49.32, listViewOpen: 154.73, minListViewOpen: 146.26, maxListViewOpen: 171.17

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Dec 5, 2023
@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 5, 2023
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Dec 5, 2023
added a read-more link to the docs
@JohnPixle
Copy link
Contributor

@HardeepAsrani Need your help with this if possible. I have tweaked the title and description in the last commit, and I added a learn more text link, that is linking the user to this url: https://docs.themeisle.com/article/1975-fse-onboarding
(currently draft). This is an article in the Otter docs.

However, I am not sure if I got the html right, can you please take a look and fix it if needed?
Thanks!

@HardeepAsrani HardeepAsrani removed pr-checklist-skip Allow this Pull Request to skip checklist. pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Dec 13, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 13, 2023
@HardeepAsrani
Copy link
Member Author

@JohnPixle I've fixed that.

fixed line heights of title and description
updated text in final step
fixed typo
@JohnPixle
Copy link
Contributor

Looking good, I just made some final tweaks at the finish page.
One final suggestion that I have is to include the label for the feedback form in the last step.

Now as I understand it is hidden with hideLabelFromVision ? I was not sure, so I did not edited that.

What you think @HardeepAsrani ?

@irinelenache
Copy link
Contributor

@HardeepAsrani Tested and everything's fine on my end regarding the onboarding 🚀

JohnPixle and others added 4 commits December 15, 2023 13:25
@JohnPixle
Copy link
Contributor

JohnPixle commented Dec 18, 2023

@HardeepAsrani Good morning, I just tested these, thanks for the update.

For the checkbox part, if it is un-checked can we hide the field as we had discussed?
If the field stays visible it kinda still implies visually that the email will be sent.

Screenshot 2023-12-18 at 10 49 44 AM

Let me know if you need help with that or any clarifications!

For the wonky behaviour of the wizard, I have not seen any change, or it might have been un-noticeable. It might have performed a bit faster, but the re-rendering still took place.

Thanks!

PS: just made two slight copy changes at the start and finish screens, they are ok.

Changed start screen copy
changed button copy at final screen
@HardeepAsrani HardeepAsrani merged commit d3bb4c3 into next Dec 18, 2023
11 checks passed
@HardeepAsrani HardeepAsrani deleted the onboarding branch December 18, 2023 12:58
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants