Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Templates for Onboarding #85

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Add Templates for Onboarding #85

merged 7 commits into from
Dec 14, 2023

Conversation

HardeepAsrani
Copy link
Member

[WIP]

All the changes related to Onboarding.

Closes #62

@HardeepAsrani
Copy link
Member Author

@JohnPixle I've added the templates here. You can separate them into Patterns and update them, or let me know if you need my assistance in doing so.

@HardeepAsrani HardeepAsrani marked this pull request as ready for review November 30, 2023 09:56
@pirate-bot
Copy link
Contributor

Plugin build for 6311dda is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for 7832c16 is ready 🛎️!

@JohnPixle JohnPixle mentioned this pull request Dec 7, 2023
Merged
@pirate-bot
Copy link
Contributor

Plugin build for 5646153 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for f43f154 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Plugin build for 5d8cfe3 is ready 🛎️!

@JohnPixle
Copy link
Contributor

@HardeepAsrani Hey sir! do you have a working demo where you test this?
Or can I use in my instance at instawp? or should I wait until you merge it into development?

I assume I should also install the dev build from Otter? Let me know, thanks in advance!

@HardeepAsrani
Copy link
Member Author

@JohnPixle You can download the zip from this PR, and the Otter build from here: Codeinwp/otter-blocks#1976 (comment)

It doesn't matter if you download the prod or dev build.

@JohnPixle
Copy link
Contributor

Thanks! 🚀

@JohnPixle
Copy link
Contributor

Works great overall, thanks for taking care of the pages and everything. I only spotted some minor issues with the text color in some dark style variations, but I will easily fix them tomorrow, just some hex values for the inverted text color. And the page refresh in each step is still there, but the loading of the thumbnails is good now.

We will talk tomorrow on our call, thanks!

@HardeepAsrani HardeepAsrani mentioned this pull request Dec 13, 2023
Merged
9 tasks
@JohnPixle JohnPixle merged commit 52e5202 into development Dec 14, 2023
8 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soare-Robert-Daniel Soare-Robert-Daniel Soare-Robert-Daniel approved these changes

Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HardeepAsrani @pirate-bot @JohnPixle @Soare-Robert-Daniel