Skip to content

Add permission callback #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 3, 2019
Merged

Add permission callback #541

merged 6 commits into from
Oct 3, 2019

Conversation

HardeepAsrani
Copy link
Member

This adds a permission callback to Rest request. @contactashish13

Copy link
Contributor

@contactashish13 contactashish13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also sanitize the data before inserting e.g. the url, source, id at the very least

Sanitized chart data before saving.
@HardeepAsrani
Copy link
Member Author

@contactashish13 Can you check?

Copy link
Contributor

@contactashish13 contactashish13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also mention the data you have tested against for each field that is being sanitized?

@HardeepAsrani
Copy link
Member Author

@contactashish13 I've resolved all the current issues. I tested the import with two URLs,

Let me know if that's enough to reproduce or you need more info. :)

@contactashish13 contactashish13 merged commit e8e0e85 into Codeinwp:development Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants