Skip to content

3.4.0 #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 169 commits into from
Feb 4, 2020
Merged

3.4.0 #561

merged 169 commits into from
Feb 4, 2020

Conversation

contactashish13
Copy link
Contributor

@contactashish13 contactashish13 commented Nov 1, 2019

Add import from wordpress and database to plan 1
For every chart show the last updated date and any error that exists
JSON import: Provide some support for authentication out of the box
Tested up to WP 5.3
PHP Fatal error: Uncaught Error: Cannot unset string offsets
Combine one time import and schedule import
Add existing features to block editor
Add support for annotation and other roles
Add Bubble charts

contactashish13 and others added 30 commits August 28, 2019 11:06
This filters the rest query to make sure no ChartJS charts are being
shown file others appear just fine, even when the meta value
visualizer-chart-library doesn's exist, which might be the case for
charts saved before the ChartJS charts were added.

Fixees the issue reported in
#531 and #506
Tested the plugin with WordPress 5.3 Beta 2. It had few deprecated
components which we have changed. Fixes #540
For every chart show the last updated date and any error that exists
Add import from wordpress and database to plan 1
@contactashish13
Copy link
Contributor Author

@rodica-andronache

  1. have created Gutenberg: annotations don't appear #609

  2. Yes that is the behavior. In fact this is consistent whenever you change the "source". This needs an overhaul soon and I guess it can be a new issue.

  3. Can you create a new issue for this?
    3a) The red cross happens with known errors - this one is new and part of JS I guess, so will need to take a look.

  4. Yes

  5. That's an area of improvement in most of the plugin documentation. It would obviously be helpful to add it for non-developers similar to https://docs.gravityforms.com/gform_confirmation/.

  6. Yes it is, although flawed, because we differentiate on the basis of the plan and show features on the basis of that. You will see that you can access non-business features but not business features. But this can be fixed but one problem is that absence of a license key is treated the same as an expiry of a valid license key. Can you create an issue with the behavior you expect when a license key is absent and expired?

@rodica-andronache
Copy link
Contributor

@contactashish13 created the issues you've mentioned and updated that doc a bit. I'll have a look at the docs as well, to see if there are any improvements that can be done. For the license thing, I need to think a bit and understand how is currently working for all plans before adding it on git

@rodica-andronache rodica-andronache merged commit 47999f3 into development Feb 4, 2020
@selul selul deleted the 3.4.0 branch October 12, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants