Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use git to fetch external project grpc #41

Merged
merged 2 commits into from
Feb 2, 2021
Merged

use git to fetch external project grpc #41

merged 2 commits into from
Feb 2, 2021

Conversation

furushchev
Copy link
Contributor

@furushchev furushchev commented Feb 2, 2021 •
edited
Loading

Currently the project fetches grpc and its dependencies by downloading TAR archives in CMakeLists.txt and all versions are hand-written.
This PR fetches grpc and all dependencies by using git submodule instead, where only the version of grpc is required to specify the version.
I think it makes it better to maintain version.

@furushchev furushchev mentioned this pull request Feb 2, 2021
Merged
@BillWSY BillWSY merged commit f6ece3a into CogRob:master Feb 2, 2021
@BillWSY
Copy link
Member

BillWSY commented Feb 2, 2021

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furushchev @BillWSY