Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't specify the patch version in go-vulncheck #369

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Don't specify the patch version in go-vulncheck #369

merged 2 commits into from
Feb 23, 2023

Conversation

lasarojc
Copy link
Contributor

go-setup now supports 1.19.6 when specifying just 1.19, so we can drop the patch version.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@lasarojc lasarojc added automerge backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x labels Feb 22, 2023
@lasarojc lasarojc requested a review from a team as a code owner February 22, 2023 12:47
@lasarojc lasarojc self-assigned this Feb 22, 2023
sergio-mena
sergio-mena approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@lasarojc lasarojc merged commit 280f4b9 into main Feb 23, 2023
@lasarojc lasarojc deleted the lasarojc/drop-patch-version-govulncheck branch February 23, 2023 14:55
@lasarojc lasarojc restored the lasarojc/drop-patch-version-govulncheck branch February 23, 2023 14:56
mergify bot pushed a commit that referenced this pull request Feb 23, 2023
@lasarojc @mergify
Don't specify the patch version in go-vulncheck (#369)
566540f 
(cherry picked from commit 280f4b9)
@mergify mergify bot mentioned this pull request Feb 23, 2023
Merged
@lasarojc lasarojc deleted the lasarojc/drop-patch-version-govulncheck branch February 23, 2023 14:57
lasarojc added a commit that referenced this pull request Feb 23, 2023
@mergify @lasarojc
Don't specify the patch version in go-vulncheck (#369) (#377)
13df01c 
(cherry picked from commit 280f4b9)

Co-authored-by: Lasaro <lasaro@informal.systems>
@lasarojc lasarojc mentioned this pull request Feb 24, 2023
Closed
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
cason pushed a commit that referenced this pull request Jan 5, 2024
@josef-widder @cason
PBTS: new minimal set of changes in consensus algorithm (#369)
f0a470b 
* PBTS: second draft of protocol specification

* PBTS: updates in consensus algorithm v2

* PBTS: adding/fixing links in second draft

* PBTS: updated links for new algorithm specification

* PBTS: changes suggested by Josef

Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com>

* PBTS: minor fixes and additions to spec

Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-mena sergio-mena sergio-mena approved these changes

@thanethomson thanethomson thanethomson approved these changes

Assignees

@lasarojc lasarojc

Labels
backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lasarojc @thanethomson @sergio-mena