Add github action to build python wheels (including python 3.9 and 3.10) #2097

jmarrec · 2022-03-14T21:27:41Z

Description of the Change

Fix Python CoolProp package doesn't work on Python 3.9.0 (32 bit and 64 bit) #1981
Adds a github action with cibuildwheel to build wheels on all platforms
Setting up some TWINE tokens would enable automatic upload to PyPi (for tags), and TestPyPi (for nightly builds / PR builds)
Note: Right now I cannot get windows x86 to build...

Benefits

Python 3.9 and 3.10 aren't supported right now.

As far as I can tell there is also no real CI running right now (nor has been for a while) but I could be wrong. At least this is what this comment seem to indicate: #1981 (comment)

This sets up github actions to produce new python wheels for all platforms and automatically upload them to PyPi/TestPyPi

I also enabled arm64 mac builds (for M1 macs / Apple silicon)

Possible Drawbacks

Mac picks ups not HAS_MOVE_SEMANTICS but C++11 mode isn't enabled, so it chokes on lambdas. For now I generally enabled C++11, not sure if that's a big deal or not... Here it'll choke on line 45

CoolProp/include/CPstrings.h

Lines 33 to 50 in 381c853

    
           /// The following code for the trim functions was taken from http://stackoverflow.com/questions/216823/whats-the-best-way-to-trim-stdstring 
        
           // trim from start 
        
           #ifdef HAS_MOVE_SEMANTICS //More robust c++11 detection https://stackoverflow.com/questions/10717502/is-there-a-preprocessor-directive-for-detecting-c11x-support 
        
           // #ifdef __cplusplus >= 201103L || (defined(_MSC_VER) && _MSC_VER >= 1900) 
        
           inline std::string& strlstrip(std::string& s) 
        
           { 
        
               s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun<int, int>(std::isspace)))); 
        
               return s; 
        
           } 
        
           #else 
        
           inline std::string &strlstrip(std::string &s) 
        
           { 
        
               s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](unsigned char ch) { 
        
                           return !std::isspace(ch); 
        
                       })); 
        
               return s; 
        
           } 
        
           #endif

Verification Process

Right now I'm just looking at whether the CI build worked or not. I have not conducted extensive testing of whether the resulting wheels are valid or not.

Applicable Issues

Fix Python CoolProp package doesn't work on Python 3.9.0 (32 bit and 64 bit) #1981

…of overloaded ‘abs(double)’ is ambiguous` Found with the manylinux_2_24_x86_64 gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516

…NT_TARGET

…e it's using pre C++11

… it should be enough

CLAassistant · 2022-03-14T21:27:47Z

All committers have signed the CLA.

jmarrec

Added a review as a walkthrough of changes

jmarrec · 2022-03-14T21:28:45Z

.github/workflows/python_cibuildwheel.yml

+        if [[ "$GITHUB_REF" == *"refs/tags"* ]]; then
+          TWINE_REPOSITORY=pypi
+          TWINE_PASSWORD=${{ secrets.PYPI_TOKEN }}
+        else
+          TWINE_REPOSITORY=testpypi
+          TWINE_PASSWORD=${{ secrets.TESTPYPI_TOKEN }}


To enable upload to PyPi and TestPyPi, you would need to add a repo secrets PYPI_TOKEN / TESTPYPI_TOKEN set to the token you get there.

Got it, I can do that when the time comes

jmarrec · 2022-03-14T21:28:57Z

.github/workflows/python_cibuildwheel.yml

+        echo "TWINE_REPOSITORY=$TWINE_REPOSITORY" >> $GITHUB_ENV
+        echo "TWINE_PASSWORD=$TWINE_PASSWORD" >> $GITHUB_ENV
+
+        twine upload wheels/*-manylinux*.whl


This I need to tweak for sure

jmarrec · 2022-03-14T21:30:24Z

CMakeLists.txt

+# Force C++11 since lambdas are used in CPStrings.h
+set(CMAKE_CXX_STANDARD 11)
+


I had to force this for mac

I think that is fine. I'm looking forward to C++11.

jmarrec · 2022-03-14T21:30:44Z

src/Backends/IF97/IF97Backend.h

        return true;
    };

    void set_phase() {
        double epsilon = 3.3e-5;                              // IAPWS-IF97 RMS saturated pressure inconsistency
-        if ((abs(_T - IF97::Tcrit) < epsilon/10.0) &&         //            RMS temperature inconsistency ~ epsilon/10
-            (abs(_p - IF97::Pcrit) < epsilon)) {              // within epsilon of [Tcrit,Pcrit]
+        if ((std::abs(_T - IF97::Tcrit) < epsilon/10.0) &&         //            RMS temperature inconsistency ~ epsilon/10


I had to fix a couple of build errors on some platforms/compilers

this one was "call to abs to ambiguous"

Fix build error: src/Backends/IF97/IF97Backend.h:54:34: error: call of overloaded ‘abs(double)’ is ambiguous

Found with the manylinux_2_24_x86_64

gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516

Correct solution I think

jmarrec · 2022-03-14T21:32:08Z

src/Backends/IF97/IF97Backend.h

@@ -44,14 +45,14 @@ class IF97Backend : public AbstractState  {
        this->_rhomass.clear();
        this->_hmass.clear();
        this->_smass.clear();
-        this->_phase = iphase_not_imposed; 
+        this->_phase = iphase_not_imposed;


(I have auto format for trailing spaces... view with ?w=1 in the URL to filter out whitespace)

jmarrec · 2022-03-14T21:32:40Z

wrappers/Python/setup.py

+    elif os.environ.get('COOLPROP_CMAKE'):
+        cmake_compiler, cmake_bitness = os.environ.get('COOLPROP_CMAKE').split(',')


Allow getting the cmake compiler and bitness from an env variable, so I can pass it to cibuildwheel

Because you need it in the build matrix?

jmarrec · 2022-03-14T21:32:59Z

wrappers/Python/setup.py

+        elif cmake_compiler == 'vc16':
+            cmake_build_args = ['--config', '"Release"']
+            if cmake_bitness == '32':
+                cmake_config_args += ['-G', '"Visual Studio 16 2019"', '-A',
+                                      'x86']
+            elif cmake_bitness == '64':
+                cmake_config_args += ['-G', '"Visual Studio 16 2019"', '-A',
+                                      'x64']
+            else:
+                raise ValueError('cmake_bitness must be either 32 or 64; got ' + cmake_bitness)
+        elif cmake_compiler == 'vc17':
+            cmake_build_args = ['--config', '"Release"']
+            if cmake_bitness == '32':
+                cmake_config_args += ['-G', '"Visual Studio 17 2022"', '-A',
+                                      'x86']
+            elif cmake_bitness == '64':
+                cmake_config_args += ['-G', '"Visual Studio 17 2022"', '-A',
+                                      'x64']
+            else:
+                raise ValueError('cmake_bitness must be either 32 or 64; got ' + cmake_bitness)


add MSVC 2019 and 2022

That's why we have "any" option, is this really needed? I recall having issues with this myself

jmarrec · 2022-03-14T21:33:14Z

wrappers/Python/setup.py

+        cmake_build_string = ' '.join(['cmake', '--build', '.', '-j',
+                                       str(cpu_count())] + cmake_build_args)


Build with multiple cores.

jmarrec · 2022-03-14T21:33:35Z

wrappers/Python/setup.py

@@ -448,6 +484,7 @@ def find_cpp_sources(root=os.path.join('..', '..', 'src'), extensions=['.cpp'],
                "Operating System :: OS Independent",
                "Topic :: Software Development :: Libraries :: Python Modules"
                ],
+               setup_requires=['Cython'],


this was a failed attempt at getting cibuildwheel to install it. I guess I could remove it.

Yeah, I would. It is needed to build, and the setup_requires is a defective setuptools feature

jmarrec · 2022-03-14T21:33:50Z

.github/workflows/python_cibuildwheel.yml

+          # Window 32 bit
+          - os: windows-latest
+            python: 38
+            bitness: 32
+            platform_id: win32
+            cmake_compiler: vc17
+            arch: x86
+            allow_failure: true
+          - os: windows-latest
+            python: 39
+            bitness: 32
+            platform_id: win32
+            cmake_compiler: vc17
+            arch: x86
+            allow_failure: true


These two I can't get to work

I think that's ok, I had issues myself with 32-bit wheels. 32-bit windows is basically obsolete.

jmarrec · 2022-03-14T21:35:24Z

The CLA appears broken, I can't sign it

Apparently the LICENSE_CLA.txt was deleted: 05daf20

jmarrec · 2022-03-14T21:39:21Z

lgtm-com · 2022-03-14T21:51:30Z

This pull request introduces 1 alert when merging a24fc20 into 381c853 - view on LGTM.com

new alerts:

1 for Module is imported more than once

ibell · 2022-03-15T02:05:48Z

This is amazing. A few others have also talked about volunteering to help with the wheels but you just jumped in and did it. Excellent work. Looking forward to getting all tests working on all platforms. Could you please also build the shared libraries and the installer and the docs? If we get that all working, we can drop entirely our old CI system that nobody will be sorry to see go.

ibell · 2022-03-15T02:06:10Z

.github/disabled_workflows/python_linux.yml

@@ -0,0 +1,71 @@
+name: Python Linux


I think this whole file needs to get removed?

it's disabled so no harm. Will clean it up later, once we're satisfied with the cibuildwheel

ibell · 2022-03-15T02:06:46Z

.github/workflows/python_cibuildwheel.yml

+          # Window 32 bit
+          - os: windows-latest
+            python: 38
+            bitness: 32
+            platform_id: win32
+            cmake_compiler: vc17
+            arch: x86
+            allow_failure: true
+          - os: windows-latest
+            python: 39
+            bitness: 32
+            platform_id: win32
+            cmake_compiler: vc17
+            arch: x86
+            allow_failure: true


I think that's ok, I had issues myself with 32-bit wheels. 32-bit windows is basically obsolete.

ibell · 2022-03-15T02:07:13Z

.github/workflows/python_cibuildwheel.yml

+        if [[ "$GITHUB_REF" == *"refs/tags"* ]]; then
+          TWINE_REPOSITORY=pypi
+          TWINE_PASSWORD=${{ secrets.PYPI_TOKEN }}
+        else
+          TWINE_REPOSITORY=testpypi
+          TWINE_PASSWORD=${{ secrets.TESTPYPI_TOKEN }}


Got it, I can do that when the time comes

ibell · 2022-03-15T02:07:31Z

CMakeLists.txt

+# Force C++11 since lambdas are used in CPStrings.h
+set(CMAKE_CXX_STANDARD 11)
+


I think that is fine. I'm looking forward to C++11.

ibell · 2022-03-15T02:07:47Z

src/Backends/IF97/IF97Backend.h

        return true;
    };

    void set_phase() {
        double epsilon = 3.3e-5;                              // IAPWS-IF97 RMS saturated pressure inconsistency
-        if ((abs(_T - IF97::Tcrit) < epsilon/10.0) &&         //            RMS temperature inconsistency ~ epsilon/10
-            (abs(_p - IF97::Pcrit) < epsilon)) {              // within epsilon of [Tcrit,Pcrit]
+        if ((std::abs(_T - IF97::Tcrit) < epsilon/10.0) &&         //            RMS temperature inconsistency ~ epsilon/10


Correct solution I think

ibell · 2022-03-15T02:08:07Z

wrappers/Python/setup.py

+    elif os.environ.get('COOLPROP_CMAKE'):
+        cmake_compiler, cmake_bitness = os.environ.get('COOLPROP_CMAKE').split(',')


Because you need it in the build matrix?

ibell · 2022-03-15T02:08:45Z

wrappers/Python/setup.py

+        elif cmake_compiler == 'vc16':
+            cmake_build_args = ['--config', '"Release"']
+            if cmake_bitness == '32':
+                cmake_config_args += ['-G', '"Visual Studio 16 2019"', '-A',
+                                      'x86']
+            elif cmake_bitness == '64':
+                cmake_config_args += ['-G', '"Visual Studio 16 2019"', '-A',
+                                      'x64']
+            else:
+                raise ValueError('cmake_bitness must be either 32 or 64; got ' + cmake_bitness)
+        elif cmake_compiler == 'vc17':
+            cmake_build_args = ['--config', '"Release"']
+            if cmake_bitness == '32':
+                cmake_config_args += ['-G', '"Visual Studio 17 2022"', '-A',
+                                      'x86']
+            elif cmake_bitness == '64':
+                cmake_config_args += ['-G', '"Visual Studio 17 2022"', '-A',
+                                      'x64']
+            else:
+                raise ValueError('cmake_bitness must be either 32 or 64; got ' + cmake_bitness)


That's why we have "any" option, is this really needed? I recall having issues with this myself

ibell · 2022-03-15T02:09:21Z

wrappers/Python/setup.py

@@ -448,6 +484,7 @@ def find_cpp_sources(root=os.path.join('..', '..', 'src'), extensions=['.cpp'],
                "Operating System :: OS Independent",
                "Topic :: Software Development :: Libraries :: Python Modules"
                ],
+               setup_requires=['Cython'],


Yeah, I would. It is needed to build, and the setup_requires is a defective setuptools feature

jmarrec · 2022-03-15T09:35:40Z

This is amazing. A few others have also talked about volunteering to help with the wheels but you just jumped in and did it. Excellent work. Looking forward to getting all tests working on all platforms. Could you please also build the shared libraries and the installer and the docs? If we get that all working, we can drop entirely our old CI system that nobody will be sorry to see go.

I can certainly help.

A quick bit of context first though: I actually don't really use CoolProp myself (I might have tried it a couple of times years ago). I work on a C++ project that exposes a python library, and I recently had to pin python to 3.8 become some users were using CoolProp and that wasn't available for 3.9+. So saw the linked issues and the call for help, so I decided to contribute because this 1) Looks like a cool OSS project, 2) I have knowledge of github actions, and 3) the cibuildwheel stuff was a nice exercise and one I hadn't tried before.

I have burned quite a few hours already on this and I am not familiar with your build system (and looking at the CMakeLists.txt, it's a bit messy if I'm allowed to say (no judgment whatsoever)). So if you can chew what you want to happen or point me to existing build scripts that'd be nice, so I don't try to reivent the wheel.

jmarrec · 2022-03-15T09:43:59Z

@ibell Adding the workflows for shared build and documentation separately in #2098

ibell · 2022-03-16T00:49:23Z

Sphinx docs-wise, they can be build with a docker container. The necessary is like this:

cat docs_runner.sh && chmod +x docs_runner.sh && ./docs_runner.sh False
 in dir /Users/ian/OSX-worker/Sphinx_docs/build/Web/docker

ibell · 2022-03-16T00:51:18Z

@jmarrec I know about the ugliness of the CMakeLists.txt. I do like having it all in one file because it makes it easier for searching, but now I would make an interface target and offer that to the wrappers.

ibell · 2022-03-20T22:34:04Z

Just for fun I got another library of mine building all the wheels that matter: https://github.com/ibell/pdsim/blob/72592669c5ec3d1a824a80ce3c2a92854fe2aca2/.github/workflows/cibuildswheels.yml . Including the arm wheels on macos. So that makes me wonder: could we simplify the cibuildwheels stuff and make fixes to coolprop itself to avoid all custom things?

jmarrec · 2022-03-28T07:09:41Z

Take that with a grain of salt (packaging external libs in C++ is something I've done but where I wouldn't claim any expertise)

There is a large amount of custom stuff you have in setup.py, so it's possible some could be simplified. But this is still a native C++ lib built via CMake, so I'm not sure you can simply take all customization away.

jmcarter17 · 2022-04-11T17:22:26Z

This was merged 11 days ago. Any ideas when we will see the result reflected in Pypi?

As of now, pypi still only has up to version 6.4.1, which was uploaded Aug 4, 2020.
So, I'm assuming the python actions to build the python 3.9 and 3.10 wheels does not work, yet.

jmarrec · 2022-04-11T19:02:07Z

Still a work in progress. I'm having a few kinks uploading to testpypi, should be resolved soon. https://github.com/CoolProp/CoolProp/runs/5976949824?check_suite_focus=true

jmcarter17 · 2022-04-11T20:19:35Z

Awesome.
Look forward to it.
Thanks for all the great job you guys are doing.

jmarrec · 2022-04-12T06:58:55Z

@jmcarter17 Jean-Michel, you can now try pip install -i https://test.pypi.org/simple/ CoolProp==6.4.2.dev0. If you could test that and report back with the operating system and Python version you're using and whether it works or not that would be great.

Edit: I made an issue to centralize test results: #2119

jmcarter17 · 2022-04-12T12:54:54Z

Worked on Mac OSX (intel), with python 3.10.3 (pyenv)

jmcarter17 · 2022-04-12T13:21:56Z

Ok, commented on the centralized test result #2119.

dflorez0 · 2022-04-12T21:54:35Z

It worked on Win10 64 with Python 3.10.2

@jmcarter17 Jean-Michel, you can now try pip install -i https://test.pypi.org/simple/ CoolProp==6.4.2.dev0. If you could test that and report back with the operating system and Python version you're using and whether it works or not that would be great.

Edit: I made an issue to centralize test results: #2119

…10) (CoolProp#2097) * Fix build error: `src/Backends/IF97/IF97Backend.h:54:34: error: call of overloaded ‘abs(double)’ is ambiguous` Found with the manylinux_2_24_x86_64 gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 * Register MSVC 2019 and 2022 in setup.py * setup.py: when calling cmake, build in parallel * Enable using Env variables instead of passing them as args to setup.py * Github actions for linux: try 1 * use actions/checkout@v3 for submodules * mod setup.py:; typo * Random shot for cibuildwheel for all platforms * I thought package_dir was a flag, but it's positional * typo in cmake_compiler * add cython to setup_requires * try a pryproject.toml to install cython * try more requirements? * pywin32 only found on win32 I guess * Try with CIBW_BEFORE_BUILD instead * try to enable msvc via vcvarsall on windows, and pass MACOSX_DEPLOYMENT_TARGET * more tweaks for windoze * disable tests for now (fails on windows) * tweak mac again: it seems mac doesn't understand a C++ lambda, so like it's using pre C++11 * tweak * try 10.15 for mac... * try to force C++11 since mac picks up the path where lambdas are used... * Move back down to 10.9 now that C++11 is enabled and it works on mac, it should be enough * Try to debug win32 * Enable part of the upload step (minus the upload) to list the wheels * try to allow win32 to fail for now (instead of plain disabling) * Disable the python_linux.yml workflow, so cibuildwheels works fine. * Adjust the upload step to point to the right folder * make LGTM python happy

jmarrec added 26 commits March 8, 2022 15:58

Fix build error: `src/Backends/IF97/IF97Backend.h:54:34: error: call …

7e9302e

…of overloaded ‘abs(double)’ is ambiguous` Found with the manylinux_2_24_x86_64 gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516

Register MSVC 2019 and 2022 in setup.py

fc0b922

setup.py: when calling cmake, build in parallel

05f61b6

Enable using Env variables instead of passing them as args to setup.py

24e70b6

Github actions for linux: try 1

f18e56c

use actions/checkout@v3 for submodules

9bf0351

mod setup.py:; typo

e33c791

Random shot for cibuildwheel for all platforms

44dcf4b

I thought package_dir was a flag, but it's positional

e9c2ea1

typo in cmake_compiler

e26c314

add cython to setup_requires

7dce640

try a pryproject.toml to install cython

09a3e11

try more requirements?

0d86eb5

pywin32 only found on win32 I guess

612b4b4

Try with CIBW_BEFORE_BUILD instead

8d3a35c

try to enable msvc via vcvarsall on windows, and pass MACOSX_DEPLOYME…

e62855b

…NT_TARGET

more tweaks for windoze

1e90588

disable tests for now (fails on windows)

6088208

tweak mac again: it seems mac doesn't understand a C++ lambda, so lik…

bc660da

…e it's using pre C++11

tweak

5c2b641

try 10.15 for mac...

798bd09

try to force C++11 since mac picks up the path where lambdas are used...

877c935

Move back down to 10.9 now that C++11 is enabled and it works on mac,…

90a4c4c

… it should be enough

Try to debug win32

dbb137e

Enable part of the upload step (minus the upload) to list the wheels

b93b386

try to allow win32 to fail for now (instead of plain disabling)

450bdbb

Disable the python_linux.yml workflow, so cibuildwheels works fine.

955cd36

jmarrec force-pushed the actions_pypi branch from ba16cae to 8186fcf Compare March 14, 2022 21:30

jmarrec commented Mar 14, 2022

View reviewed changes

jmarrec force-pushed the actions_pypi branch from 8186fcf to 955cd36 Compare March 14, 2022 21:36

Adjust the upload step to point to the right folder

a24fc20

make LGTM python happy

6bec2d9

ibell reviewed Mar 15, 2022

View reviewed changes

jmarrec mentioned this pull request Mar 15, 2022

Github Actions: add shared library and doxygen workflows. #2098

Merged

ibell merged commit 149a40d into CoolProp:master Mar 31, 2022

jmarrec deleted the actions_pypi branch March 31, 2022 15:24

joroeder mentioned this pull request Apr 21, 2022

Add pre-calc hydraulic module oemof/DHNx#82

Merged

7 tasks

bilke mentioned this pull request Apr 22, 2022

Drop requirement Python < 3.9? oemof/tespy#252

Closed

jowr added this to the v6.4.2 milestone Dec 7, 2022

	/// The following code for the trim functions was taken from http://stackoverflow.com/questions/216823/whats-the-best-way-to-trim-stdstring
	// trim from start
	#ifdef HAS_MOVE_SEMANTICS //More robust c++11 detection https://stackoverflow.com/questions/10717502/is-there-a-preprocessor-directive-for-detecting-c11x-support
	// #ifdef __cplusplus >= 201103L \|\| (defined(_MSC_VER) && _MSC_VER >= 1900)
	inline std::string& strlstrip(std::string& s)
	{
	s.erase(s.begin(), std::find_if(s.begin(), s.end(), std::not1(std::ptr_fun<int, int>(std::isspace))));
	return s;
	}
	#else
	inline std::string &strlstrip(std::string &s)
	{
	s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](unsigned char ch) {
	return !std::isspace(ch);
	}));
	return s;
	}
	#endif

		# Force C++11 since lambdas are used in CPStrings.h
		set(CMAKE_CXX_STANDARD 11)

		elif os.environ.get('COOLPROP_CMAKE'):
		cmake_compiler, cmake_bitness = os.environ.get('COOLPROP_CMAKE').split(',')

		cmake_build_string = ' '.join(['cmake', '--build', '.', '-j',
		str(cpu_count())] + cmake_build_args)

Add github action to build python wheels (including python 3.9 and 3.10) #2097

Add github action to build python wheels (including python 3.9 and 3.10) #2097

Conversation

jmarrec commented Mar 14, 2022 • edited Loading

Description of the Change

Benefits

Possible Drawbacks

Verification Process

Applicable Issues

CLAassistant commented Mar 14, 2022 • edited Loading

jmarrec left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented Mar 14, 2022 • edited Loading

jmarrec commented Mar 14, 2022 • edited Loading

Tested

Linux

Mac, x86_64

Windows

Mac, arm64: failing

lgtm-com bot commented Mar 14, 2022

ibell commented Mar 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented Mar 15, 2022 • edited Loading

jmarrec commented Mar 15, 2022

ibell commented Mar 16, 2022

ibell commented Mar 16, 2022

ibell commented Mar 20, 2022

jmarrec commented Mar 28, 2022

jmcarter17 commented Apr 11, 2022

jmarrec commented Apr 11, 2022

jmcarter17 commented Apr 11, 2022

jmarrec commented Apr 12, 2022 • edited Loading

jmcarter17 commented Apr 12, 2022

jmcarter17 commented Apr 12, 2022

dflorez0 commented Apr 12, 2022

jmarrec commented Mar 14, 2022 •

edited

Loading

CLAassistant commented Mar 14, 2022 •

edited

Loading

jmarrec commented Mar 14, 2022 •

edited

Loading

jmarrec commented Mar 14, 2022 •

edited

Loading

jmarrec commented Mar 15, 2022 •

edited

Loading

jmarrec commented Apr 12, 2022 •

edited

Loading