x/wasm: add AllDenomMetadata BankQuery #1294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
alpe
suggested changes
Mar 27, 2023
There was a problem hiding this comment.
Thank you for your PR! 💐
Good work on all layers. I have added some notes and also commented on CosmWasm/cosmwasm#1647. Let's discuss the feature there.
| @@ -182,4 +182,6 @@ replace ( | |||
|
|
|||
| // pin version! 126854af5e6d has issues with the store so that queries fail | |||
| github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | |||
|
|
|||
| github.com/CosmWasm/wasmvm => ../wasmvm | |||
There was a problem hiding this comment.
This is a local development setup and should be removed
There was a problem hiding this comment.
Yes. I have left this in until the corresponding wasmvm PR is merged - CosmWasm/wasmvm#409. Once that is merged, I will open a separate PR to upgrade wasmvm, and then rebase and remove this change.
Leaving this comment as unresolved until that happens.
| }) | ||
| require.NoError(t, gotErr) | ||
| var got keeper.AllDenomMetadataResponse | ||
| require.NoError(t, json.Unmarshal(gotBz, &got)) |
nik-suri
force-pushed
the
denom-metadata-query
branch
2 times, most recently
from
4b00ad6 to
b93adf0
Compare
nik-suri
force-pushed
the
denom-metadata-query
branch
from
b93adf0 to
8b51b67
Compare
|
Closing in favor of #1426. Thanks @chipshort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review these related PRs in tandem: