Allow bool as type for AA keys. #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added a commit
that referenced
this pull request
Jun 5, 2011
Allow bool as type for AA keys.
|
This has been reverted in cce360c. Did my commit cause any bugs I hadn't noticed, or did the revert just slip in? |
|
I guess this snafu demonstrates that test case code needs to be provided for each pull request. |
|
Yes, absolutely – I am not quite sure why I didn't include the commit containing the test case here… |
|
I restored it: 5ac7c66 |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Sep 15, 2011
[fix for previous commit]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't really seem to be a reason why AA keys of type bool are not allowed, and the docs don't mention anything either. The restriction has been put in place back in the »bit« days, maybe there was a related limitation back then?
bool-key AAs probably wouldn't be too useful in practice, but it seems like a quite arbitrary and unexpected limitation to me – e.g. I would have to add special cases all over my Thrift map handling code.