Issue 5718 - Can't demangle symbol defined inside unittest block #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std.traits.mangledName should return valid mangled name against symbols in function.
| else | ||
| { | ||
| enum string mangledName = sth[0].mangleof; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Just as an aside, I'm certain that I wrote the original version of that code. It was originally called "mangleNameOf", and was published on the ng and in DDL project on dsource. Somebody copied it verbatim and republished it another dsource project with my name removed and most of the comments stripped out, but with the function names unchanged. I think this code is based on that. This code still doesn't include the comments explaining why it works, and it really needs to. It took a lot of creativity to come up with, it's really not obvious.
|
Don, please add your explanatory comments & credit back in (in a separate pull, as I'm pulling this one now). |
WalterBright
added a commit
that referenced
this pull request
Feb 1, 2012
Issue 5718 - Can't demangle symbol defined inside unittest block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=5718
std.traits.mangledName should return valid mangled name against symbols in function.