Skip to content

Conversation

sharanyashastry
Copy link
Contributor

@sharanyashastry sharanyashastry commented May 15, 2025

Upgraded Drake from version 1.22.0 to 1.33.0. This is the latest version that built without needing any additional changes.


This change is Reviewable

@sharanyashastry sharanyashastry requested review from ebianchi and mposa May 15, 2025 19:48
@ebianchi
Copy link

ebianchi commented May 16, 2025

Testing a fresh install, I get the following "issues," though everything still builds properly:

  • Running the installation script sudo ./install/install_prereqs_jammy.sh gets the error (related to Fix install script #367):
    • FIX: This will be fixed if the changes to install_prereqs_jammy.sh are brought into this PR (as they should).
./source_distribution/install_prereqs.sh: line 116: ./source_distribution/install_bazelisk.sh: No such file or directory
  • Bazel building with bazel build ... gives the warning that it's creating an empty file (that git then marks as an untracked file):
    • FIX: Two options here: migrate from WORKSPACE.bazel to MODULE.bazel, or add the line common --noenable_bzlmod to .bazelrc to disable Bzlmod.
WARNING: --enable_bzlmod is set, but no MODULE.bazel file was found at the workspace root. Bazel will create an empty MODULE.bazel file. Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. For more details, please refer to https://github.com/bazelbuild/bazel/issues/18958.

@sharanyashastry sharanyashastry marked this pull request as ready for review May 19, 2025 18:02
@sharanyashastry
Copy link
Contributor Author

Updated:

  1. Brought the changes to install_prereqs_jammy.sh into this PR.
  2. Added the line common --noenable_bzlmod to the .bazelrc to disable Bzlmod.

Tested a clean build that built with neither of the above warnings.

Copy link

@ebianchi ebianchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the build worked without issues, and no files were inadvertently added.

wget "https://raw.githubusercontent.com/RobotLocomotion/drake/${DRAKE_COMMIT}/setup/ubuntu/source_distribution/packages-${ubuntu_codename}-clang.txt"
wget "https://raw.githubusercontent.com/RobotLocomotion/drake/${DRAKE_COMMIT}/setup/ubuntu/source_distribution/packages-${ubuntu_codename}-test-only.txt"
wget "https://raw.githubusercontent.com/RobotLocomotion/drake/${DRAKE_COMMIT}/setup/ubuntu/source_distribution/install_bazelisk.sh"
wget "https://raw.githubusercontent.com/RobotLocomotion/drake/${DRAKE_COMMIT}/setup/ubuntu/source_distribution/install_bazel.sh"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line gives an error:

--2025-05-19 16:11:57--  https://raw.githubusercontent.com/RobotLocomotion/drake/v1.33.0/setup/ubuntu/source_distribution/install_bazel.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 2606:50c0:8000::154, 2606:50c0:8003::154, 2606:50c0:8001::154, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2606:50c0:8000::154|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-05-19 16:11:58 ERROR 404: Not Found.

However this isn't consequential given install_bazelisk.sh does successfully install. This might've been written this way to accommodate many versions of Drake that have only one or the other. Seems fine to leave to me.

@ebianchi ebianchi merged commit 5d86320 into sampling_based_c3_public May 20, 2025
1 of 4 checks passed
@ebianchi ebianchi deleted the sampling_based_c3_PR1 branch May 20, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants