-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tabbing behavior #95
Merged
wordshaker
merged 14 commits into
DDDEastMidlandsLimited:master
from
kaylakremer:add-tabbing-behavior
Oct 7, 2019
Merged
Add tabbing behavior #95
wordshaker
merged 14 commits into
DDDEastMidlandsLimited:master
from
kaylakremer:add-tabbing-behavior
Oct 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
From a quick glance, this looks great. I'll give it a thorough test over the next couple of days. |
wordshaker
added
accessibility
Covers an accessibility concern
enhancement
New feature or request
hacktober
In progress
labels
Oct 5, 2019
wordshaker
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
I added tab indexes throughout the website so that users can navigate with the use of the
tab
andshift-tab
buttons. In addition to the navigation and links having focus, I also added focus to the paragraphs and list items so that someone with a screen reader will be able to hear the information. Some HTML tags were also edited to be picked up better by a screen reader. For example, a subheader with just a<strong>
tag was changed to use<h4>
instead.Benefits
With the tab indexes added, users who rely on a11y should now be able to click on all links and be able to hear all pertinent information on a screenreader.
Applicable Issues
I broke down the tab indexes to focus on every paragraph and list item as mentioned above, but perhaps you might not want this many tab indexes? Also, although I did not add it since it was not asked in the requirements, but it is often a good idea to include a button to
skip to main content
that is only visible to a screen reader and is focusable. This way, a user does not have to always tab through the nav bar at the top every time they load a page on your site to get to the page's content.