Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop: 0.59.2 → 0.69.0 (major) #38

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented May 14, 2019


Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.59.2 → 0.69.0) · Repo · Changelog

Release Notes

0.69.0

New features

  • Add support for subclassing using Class.new to Lint/InheritException. (@houli)
  • #6779: Add new cop Style/NegativeUnless that checks for unless with negative condition. (@tejasbubane)

Bug fixes

  • #6900: Fix Rails/TimeZone autocorrect Time.current to Time.zone.now. (@vfonic)
  • #6900: Fix Rails/TimeZone to prefer Time.zone.#{method} over other acceptable corrections. (@vfonic)
  • #7007: Fix Style/BlockDelimiters with braces_for_chaining style false positive, when chaining using safe navigation. (@Darhazer)
  • #6880: Fix .rubocop file parsing. (@hoshinotsuyoshi)
  • #5782: Do not autocorrect Lint/UnifiedInteger if TargetRubyVersion < 2.4. (@lavoiesl)
  • #6387: Prevent Lint/NumberConversion from reporting error with Time/DateTime. (@tejasbubane)
  • #6980: Fix Style/StringHashKeys to allow string as keys for hash arguments to gsub methods. (@tejasbubane)
  • #6969: Fix a false positive with block methods in Style/InverseMethods. (@dduugg)
  • #6729: Handle array spread for change_column_default in Rails/ReversibleMigration cop. (@tejasbubane)
  • #7033: Fix an error for Layout/EmptyLineAfterGuardClause when guard clause is a ternary operator. (@koic)

Changes

  • #6945: Drop support for Ruby 2.2. (@koic)
  • #6945: Set default EnforcedStyle to squiggly option for Layout/IndentHeredoc and auto_detection option is removed. (@koic)
  • #6945: Set default EnforcedStyle to always option for Style/FrozenStringLiteralComment and when_needed option is removed. (@koic)
  • #7027: Allow unicode/display_width dependency version 1.6.0. (@tagliala)

0.68.1

Bug fixes

  • #6993: Allowing for empty if blocks, preventing Style/SafeNavigation from crashing. (@RicardoTrindade)
  • #6995: Fix an incorrect auto-correct for Style/RedundantParentheses when enclosed in parentheses at while-post or until-post. (@koic)
  • #6996: Fix a false positive for Style/RedundantFreeze when freezing the result of String#*. (@bquorning)
  • #6998: Fix autocorrect of Naming/RescuedExceptionsVariableName to also rename all references to the variable. (@Darhazer)
  • #6992: Fix unknown default configuration for Layout/IndentFirstParameter cop. (@drenmi)
  • #6972: Fix a false positive for Style/MixinUsage when using inside block and if condition is after include. (@koic)
  • #6738: Prevent auto-correct conflict of Style/Next and Style/SafeNavigation. (@hoshinotsuyoshi)
  • #6847: Fix Style/BlockDelimiters to properly check if the node is chaned when braces_for_chaining is set. (@att14)

0.68.0

New features

  • #6973: Add always_braces to Style/BlockDelimiter. (@iGEL)
  • #6841: Node patterns can now match children in any order using <>. (@marcandre)
  • #6928: Add --init option for generate .rubocop.yml file in the current directory. (@koic)
  • Add new Layout/HeredocArgumentClosingParenthesis cop. (@maxh)
  • #6895: Add support for XDG config home for user-config. (@Mange, @tejasbubane)
  • Add initial autocorrection support to Metrics/LineLength. (@maxh)
  • Add Layout/IndentFirstParameter. (@maxh)
  • #6974: Make Layout/FirstMethodArgumentLineBreak aware of calling using super. (@koic)
  • Add new Lint/HeredocMethodCallPosition cop. (@maxh)

Bug fixes

  • Do not annotate message with cop name in JSON output. (@elebow)
  • #6914: Fix an error for Rails/RedundantAllowNil when with interpolations. (@Blue-Pix)
  • #6888: Fix an error for Rails/ActiveRecordOverride when no parent_class present. (@diachini)
  • #6941: Add missing absence validations to Rails/Validation. (@jmanian)
  • #6926: Allow nil values to unset config defaults. (@dduugg)
  • #6946: Allow Rails/ReflectionClassName to use string interpolation for class_name. (@r7kamura)
  • #6778: Fix a false positive in Style/HashSyntax cop when a hash key is an interpolated string and EnforcedStyle is ruby19_no_mixed_keys. (@tatsuyafw)
  • #6902: Fix a bug where Naming/RescuedExceptionsVariableName would handle an only first rescue for multiple rescue groups. (@tatsuyafw)
  • #6860: Prevent auto-correct conflict of Style/InverseMethods and Style/Not. (@hoshinotsuyoshi)
  • #6935: Layout/AccessModifierIndentation should ignore access modifiers that apply to specific methods. (@deivid-rodriguez)
  • #6956: Prevent auto-correct confliction of Lint/Lambda and Lint/UnusedBlockArgument. (@koic)
  • #6915: Fix false positive in Style/SafeNavigation when a modifier if is safe guarding a method call being passed to break, fail, next, raise, return, throw, and yield. (@rrosenblum)
  • #6822: Fix Lint/LiteralInInterpolation autocorrection for single quotes. (@hoshinotsuyoshi)
  • #6985: Fix an incorrect auto-correct for Lint/LiteralInInterpolation if contains array percent literal. (@yakout)

Changes

  • #6966: Mark Rails/TimeZone as unsafe. (@vfonic)
  • #5977: Remove Performance cops. (@koic)
  • Add auto-correction to Naming/RescuedExceptionsVariableName. (@anthony-robin)
  • #6903: Handle variables prefixed with _ in Naming/RescuedExceptionsVariableName cop. (@anthony-robin)
  • #6917: Bump Bundler dependency to >= 1.15.0. (@koic)
  • Add --auto-gen-only-exclude to the command outputted in rubocop_todo.yml if the option is specified. (@dvandersluis)
  • #6887: Allow Lint/UnderscorePrefixedVariableName cop to be configured to allow use of block keyword args. (@dduugg)
  • #6885: Revert adding psych >= 3.1 as runtime dependency. (@andreaseger)
  • Rename Layout/FirstParameterIndentation to Layout/IndentFirstArgument. (@maxh)
  • Extract method call argument alignment behavior from Layout/AlignParameters into Layout/AlignArguments. (@maxh)
  • Rename IndentArray and IndentHash to IndentFirstArrayElement and IndentFirstHashElement. (@maxh)

0.67.2

Bug fixes

  • #6882: Fix an error for Rails/RedundantAllowNil when not using both allow_nil and allow_blank. (@koic)

0.67.1

Changes

  • #6881: Set default PreferredName to e for Naming/RescuedExceptionsVariableName. (@koic)

0.67.0

New features

  • #5184: Add new multiline element line break cops. (@maxh)
  • Add new cop Rails/ActiveRecordOverride that checks for overriding Active Record methods instead of using callbacks. (@elebow)
  • Add new cop Rails/RedundantAllowNil that checks for cases when allow_blank makes allow_nil unnecessary in model validations. (@elebow)
  • Add new Naming/RescuedExceptionsVariableName cop. (@AdrienSldy)

Bug fixes

  • #6761: Make Naming/UncommunicativeMethodParamName account for param names prefixed with underscores. (@thomthom)
  • #6855: Fix an exception in Rails/RedundantReceiverInWithOptions when the body is empty. (@ericsullivan)
  • #6856: Fix auto-correction for Style/BlockComments when the file is missing a trailing blank line. (@ericsullivan)
  • #6858: Fix an incorrect auto-correct for Lint/ToJSON when there are no to_json arguments. (@koic)
  • #6865: Fix deactivated StyleGuideBaseURL for Layout/ClassStructure. (@aeroastro)
  • #6868: Fix Rails/LinkToBlank auto-correct bug when using symbol for target. (@r7kamura)
  • #6869: Fix false positive for Rails/LinkToBlank when rel is a symbol value. (@r7kamura)
  • Add IncludedMacros param to default rubocop config for Style/MethodCallWithArgsParentheses. (@maxh)
  • #6785: Do not register an offense for Rails/Present or Rails/Blank in an unless else context when Style/UnlessElse is enabled. (@rrosenblum)

Changes

  • #6854: Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. (@urbanautomaton)
  • #5977: Warn for Performance Cops. (@koic)
  • #6637: Move LstripRstrip from Performance to Style department and rename it to Strip. (@anuja-joshi)
  • #6875: Mention block form of Struct.new in Style/StructInheritance. (@XrXr)
  • #6871: Move Performance/RedundantSortBy, Performance/UnneededSort and Performance/Sample to the Style department. (@bbatsov)

0.66.0

New features

  • #6393: Add AllowBracesOnProceduralOneLiners option to fine-tune Style/BlockDelimiter's semantic mode. (@davearonson)
  • #6383: Add AllowBeforeTrailingComments option on Layout/ExtraSpacing cop. (@davearonson)
  • New cop Lint/SafeNavigationWithEmpty checks for foo&.empty? in conditionals. (@rspeicher)
  • Add new Style/ConstantVisibility cop for enforcing visibility declarations of class and module constants. (@drenmi)
  • #6378: Add Lint/ToJSON cop to enforce an argument when overriding #to_json. (@allcentury)
  • #6346: Add auto-correction to Rails/TimeZone. (@dcluna)
  • #6840: Node patterns now allow unlimited elements after .... (@marcandre)

Bug fixes

  • #4321: Fix false offense for Style/RedundantSelf when the method is also defined on Kernel. (@mikegee)
  • #6821: Fix false negative for Rails/LinkToBlank when _blank is a symbol. (@Intrepidd)
  • #6699: Fix infinite loop for Layout/IndentationWidth and Layout/IndentationConsistency when bad modifier indentation before good method definition. (@koic)
  • #6777: Fix a false positive for Style/TrivialAccessors when using trivial reader/writer methods at the top level. (@koic)
  • #6799: Fix errors for Style/ConditionalAssignment, Style/IdenticalConditionalBranches, Lint/ElseLayout, and Layout/IndentationWidth with empty braces. (@pocke)
  • #6802: Fix auto-correction for Style/SymbolArray with array contains interpolation when EnforcedStyle is brackets. (@pocke)
  • #6797: Fix false negative for Layout/SpaceAroundBlockParameters on block parameter with parens. (@pocke)
  • #6798: Fix infinite loop for Layout/SpaceAroundBlockParameters with EnforcedStyleInsidePipes: :space. (@pocke)
  • #6803: Fix error for Style/NumericLiterals on a literal that contains spaces. (@pocke)
  • #6801: Fix auto-correction for Style/Lambda with no-space argument. (@pocke)
  • #6804: Fix auto-correction of Style/NumericLiterals on numeric literal with exponent. (@pocke)
  • #6800: Fix an incorrect auto-correct for Rails/Validation when method arguments are enclosed in parentheses. (@koic)
  • #6808: Prevent false positive in Naming/ConstantName when assigning a frozen range. (@drenmi)
  • Fix the calculation of Metrics/AbcSize. Comparison methods and else branches add to the comparison count. (@rrosenblum)
  • #6791: Allow Rails/ReflectionClassName to use symbol argument for class_name. (@unasuke)
  • #5465: Fix Layout/ClassStructure to allow grouping macros by their visibility. (@gprado)
  • #6461: Restrict Ctrl-C handling to RuboCop's loop and simplify it to a single phase. (@deivid-rodriguez)

Changes

  • Add $stdout/$stderr and STDOUT/STDERR method calls to Rails/Output. (@elebow)
  • #6688: Add iterator? to deprecated methods and prefer block_given? instead. (@tejasbubane)
  • #6806: Remove powerpack dependency. (@dduugg)
  • #6810: Exclude gemspec file by default for Metrics/BlockLength cop. (@koic)
  • #6813: Allow unicode/display_width dependency version 1.5.0. (@tagliala)
  • Make Style/RedundantFreeze aware of methods that will produce frozen objects. (@rrosenblum)
  • #6675: Avoid printing deprecation warnings about constants. (@elmasantos)
  • #6746: Avoid offense on $stderr.puts with no arguments. (@luciamo)
  • Replace md5 with sha1 for FIPS compliance. (@dirtyharrycallahan)

0.65.0

New features

  • #6126: Add an experimental strict mode to Style/MutableConstant that will freeze all constants, rather than just literals. (@rrosenblum)

Bug fixes

  • #6765: Fix false positives in keyword arguments for Style/MethodCallWithArgsParentheses omit_parentheses. (@gsamokovarov)
  • #6763: Fix false positives in range literals for Style/MethodCallWithArgsParentheses omit_parentheses. (@gsamokovarov)
  • #6748: Fix Style/RaiseArgs auto-correction breaking in contexts that require parentheses. (@drenmi)
  • #6751: Prevent Style/OneLineConditional from breaking on retry and break keywords. (@drenmi)
  • #6755: Prevent Style/TrailingCommaInArgument from breaking when a safe method call is chained on the offending method. (@drenmi, @hoshinotsuyoshi)

Changes

  • #6766: Drop support for Ruby 2.2.0 and 2.2.1. (@pocke)
  • #6733: Warn duplicated keys in .rubocop.yml. (@pocke)
  • #6613: Mark Style/ModuleFunction as SafeAutocorrect: false and disable autocorrect by default. (@dduugg)

0.64.0

New features

  • #6704: Add new Rails/ReflectionClassName cop. (@Bhacaz)
  • #6643: Support AllowParenthesesInCamelCaseMethod option on Style/MethodCallWithArgsParentheses omit_parentheses. (@dazuma)

Bug fixes

  • #6254: Fix Layout/RescueEnsureAlignment for non-local assignments. (@marcotc)
  • #6648: Fix auto-correction of Style/EmptyLiteral when Hash.new is passed as the first argument to super. (@rrosenblum)
  • #6351: Fix a false positive for Layout/ClosingParenthesisIndentation when first argument is multiline. (@antonzaytsev)
  • #6689: Support more complex argument patterns on Rails/Validation auto-correction. (@r7kamura)
  • #6668: Fix autocorrection for Style/UnneededCondition when conditional has the unless form. (@mvz)
  • #6382: Fix Layout/IndentationWidth with Layout/EndAlignment set to start_of_line. (@dischorde, @siegfault, @mhelmetag)
  • #6710: Fix Naming/MemoizedInstanceVariableName on method starts with underscore. (@pocke)
  • #6722: Fix an error for Style/OneLineConditional when then branch has no body. (@koic)
  • #6702: Fix TrailingComma regression where heredoc with commas caused false positives. (@abrom)
  • #6737: Fix an incorrect auto-correct for Rails/LinkToBlank when link_to method arguments are enclosed in parentheses. (@koic)
  • #6720: Fix detection of :native line ending for Layout/EndOfLine on JRuby. (@enkessler)

Changes

  • #6597: Style/LineEndConcatenation is now known to be unsafe for auto-correct. (@jaredbeck)
  • #6725: Mark Style/SymbolProc as unsafe for auto-correct. (@drenmi)
  • #6708: Make Style/CommentedKeyword allow the :yields: RDoc comment. (@bquorning)
  • #6749: Make some cops aware of safe navigation operator. (@hoshinotsuyoshi)

0.63.1

Bug fixes

  • #6678: Fix Lint/DisjunctiveAssignmentInConstructor when it finds an empty constructor. (@rmm5t)
  • Do not attempt to auto-correct mass assignment or optional assignment in Rails/RelativeDateConstant. (@rrosenblum)
  • Fix auto-correction of Style/WordArray and Style/SymbolArray when all elements are on separate lines and there is a trailing comment after the closing bracket. (@rrosenblum)
  • Fix an exception that occurs when auto-correcting Layout/ClosingParenthesesIndentation when there are no arguments. (@rrosenblum)

Not all release notes shown. View the full release notes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ jaro_winkler (indirect, 1.5.1 → 1.5.2) · Repo · Changelog

Release Notes

1.5.2 (from changelog)

Bug Fixes

  • raises TypeError when input type is not string (c146491), closes #24
  • memory: make sure codepoints will be allocated/freed after rb_raise to prevent memory leak (fe9d784), closes #20

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 8 commits:

↗️ parallel (indirect, 1.12.1 → 1.17.0) · Repo

Commits

See the full diff on Github. The new version differs by 70 commits:

↗️ parser (indirect, 2.5.1.2 → 2.6.3.0) · Repo · Changelog

Release Notes

2.6.3.0 (from changelog)

Features implemented:

  • ruby27.y: Added beginless ranges support. (#570) (Ilya Bylich)

2.6.2.1 (from changelog)

API modifications:

  • Bump 2.4 branch to 2.4.6. (#569) (Ilya Bylich)
  • Lexer should know about current parsing context. (#566) (Ilya Bylich)

2.6.2.0 (from changelog)

API modifications:

  • Bump ruby versions to 2.5.5 and 2.6.2. (#563) (Ilya Bylich)
  • Bump Ruby version to 2.6.1. (#554) (Ilya Bylich)

Features implemented:

  • ruby27.y: dsym should be treated as string. (#560) (Ilya Bylich)
  • ruby27.y: Refactored symbol rules. (#557) (Ilya Bylich)
  • ruby27.y: Added method reference operator. (#556) (Ilya Bylich)
  • ruby27.y: branch parser. (#546) (Ilya Bylich)

2.6.0.0 (from changelog)

API modifications:

  • 2.6.0 was released, unmark is as -dev. (#538) (Ilya Bylich)

Bugs fixed:

  • Fix parsing of "\\n" escaped sequences in various literals. (#539) (Ilya Bylich)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 33 commits:

↗️ unicode-display_width (indirect, 1.4.0 → 1.6.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 19 commits:

🗑️ powerpack (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 14, 2019
@depfu
Copy link
Author

depfu bot commented May 22, 2019

Closed in favor of #42.

@depfu depfu bot closed this May 22, 2019
@depfu depfu bot deleted the depfu/update/rubocop-0.69.0 branch May 22, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants