Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Judgehost page gives error on JS datatables #885

Closed
nickygerritsen opened this issue Oct 29, 2020 · 3 comments · Fixed by #894
Closed

Judgehost page gives error on JS datatables #885

nickygerritsen opened this issue Oct 29, 2020 · 3 comments · Fixed by #894
Labels
bug web interface

Comments

@nickygerritsen
Copy link
Member

When staying on the judgehost page datatables seem to be called more than once, which breaks. See attached screenshot.
CannotDatatable
@meisterT
Copy link
Member

meisterT commented Nov 2, 2020

How can I reproduce this? I don't see it when just idling on the judgehosts page. Neither on my local installation nor on demoweb.

@nickygerritsen
Copy link
Member Author

I'm not sure. This was reported on the mailinglist.

@thijskh
Copy link
Member

thijskh commented Nov 2, 2020

More information about the error is on https://datatables.net/manual/tech-notes/3

thijskh added a commit that referenced this issue Nov 7, 2020
@thijskh
Add 'retrieve' flag for DataTables initialisation.
571dffb 
This is so that if we refresh the table with Ajax, we do not try
to reinitialize the DataTable object, since that is not supported.

See: https://datatables.net/manual/tech-notes/3#retrieve

Closes: #885
@thijskh thijskh mentioned this issue Nov 7, 2020
Merged
eldering pushed a commit that referenced this issue Nov 7, 2020
@thijskh @eldering
Add 'retrieve' flag for DataTables initialisation.
01c3b23 
This is so that if we refresh the table with Ajax, we do not try
to reinitialize the DataTable object, since that is not supported.

See: https://datatables.net/manual/tech-notes/3#retrieve

Closes: #885
thijskh added a commit that referenced this issue Nov 7, 2020
@thijskh
Add 'retrieve' flag for DataTables initialisation.
6ad8f47 
This is so that if we refresh the table with Ajax, we do not try
to reinitialize the DataTable object, since that is not supported.

See: https://datatables.net/manual/tech-notes/3#retrieve

Closes: #885
(cherry picked from commit 01c3b23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'retrieve' flag for DataTables initialisation. DOMjudge/domjudge
3 participants
@meisterT @nickygerritsen @thijskh