Fix event feed last event ID lookup. #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been added in DOMjudge@ef8c832 The first `eventid` will be 1. If the event feed reading client does not pass in a `since_token` or `since_id`, we set `since_id` to `-1` to signal start reading from the beginning. In that case there is no previous event that can be expected to exist.
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: webapp/src/Controller/API/ContestController.php
Did you find this useful? React with a 👍 or 👎 |
nickygerritsen
approved these changes
Oct 6, 2024
eldering
approved these changes
Oct 8, 2024
|
Looks like a typo I overlooked and that wasn't tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been added in ef8c832
The first
eventidwill be 1. If the event feed reading client does not pass in asince_tokenorsince_id, we setsince_idto-1to signal start reading from the beginning. In that case there is no previous event that can be expected to exist.This was also reported as broken in a side comment of #2728