Submission diff unchanged #3070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently buttons for all changed files are shown at once. Only the buttons of the selected file should be shown.
brinky
force-pushed
the
submission_diff_unchanged
branch
2 times, most recently
from
10fc358 to
9d3352f
Compare
brinky
force-pushed
the
submission_diff_unchanged
branch
from
9d3352f to
88946df
Compare
meisterT
approved these changes
Sep 3, 2025
eldering
pushed a commit
that referenced
this pull request
Sep 3, 2025
meisterT
pushed a commit
to meisterT/domjudge
that referenced
this pull request
Sep 6, 2025
(cherry picked from commit 3957fcd)
meisterT
pushed a commit
to meisterT/domjudge
that referenced
this pull request
Sep 7, 2025
(cherry picked from commit 3957fcd)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 7, 2025
(cherry picked from commit 3957fcd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submission had no changes the diff is empty and there was no way in the interface to switch to edit files.
Even worse is the case of only added files. There the files are not even available in a previous submission.
If that would be a relevant use case, the interface could be improved somehow to show more information than an edit and download button. But that might mean to merge submission_source and submission_diff.