Allow www-data to store the files from import-contest #3110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set the mask explicit to the most loose configuration to prevent the ACL effectively allowing less than configured.
vmcj
force-pushed
the
makefile_upload_logos
branch
from
8a2bc71 to
4970bff
Compare
|
The changes look fine, but I wonder: how comes that we didn't need this before, e.g. my maintainer install is working fine without it. I don't remember doing these steps manually, but perhaps I forgot. |
I think your git checkout is on a much better location than mine is, you most likely use And we've had some issues with those ACLs not being set for WF setups. I think this is part of that problem, every OS can set those defaults different. |
meisterT
approved these changes
Sep 25, 2025
Kevinjil
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On none standard locations the extended ACLs wouldn't allow this. I've now specified those explicit but I think giving access to the whole images dir would be easier and more future proof as alternative. It would give the web server access to change the DOMjudge logo though which it never needs to do (and would be an indication of broad access).