Skip to content

Always display all files (even unchanged) for a submission. #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Always display all files (even unchanged) for a submission. #3129

wants to merge 1 commit into from

Conversation

meisterT
Copy link
Member

Fixes #3115

@meisterT
Copy link
Member Author

Alternative to https://github.com/DOMjudge/domjudge/pull/3126/files

@meisterT meisterT requested a review from vmcj September 29, 2025 17:19
vmcj
vmcj reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first solution I had and I didn't really like the extra switching between true/false.

If you like this that much more it's fine by me but I would still want to wait for Kevin his review as he had an opinion on how this should work.

@meisterT
Copy link
Member Author

What do you think about this then? #3130

Less ifs.

@meisterT meisterT requested a review from Kevinjil September 29, 2025 18:45
@meisterT meisterT closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmcj vmcj vmcj left review comments

@Kevinjil Kevinjil Awaiting requested review from Kevinjil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submission source missing
2 participants
@meisterT @vmcj