Give back unfinished judgings in repeated rejudgings. #3136
Conversation
There was a problem hiding this comment.
Just to understand how this is cause for the bug (and probably good to add a summary to the commit): this endpoint is called every time that a judgehost checks in or only when it connects the first time on startup?
And shouldn't giving back these judgings happen when the rejudging is cancelled?
|
Good question, I reworded the commit, let me know if this answers everything. |
|
The third paragraph doesn't read nice in the commit. |
judgedaemons check in after start-up and after failed judgetask, see https://github.com/DOMjudge/domjudge/blob/2222a867f99275cbdb8e81d4681e47522a29669f/judge/judgedaemon.main.php#L984 Checking in has the side effect that judgetasks that no longer need to be executed are given back. Previously, we checked whether either the judging or the rejudging was valid, assuming that active rejudgings are marked as valid. This is not true for repeated rejudgings where only the last instance is "valid". For the check, it doesn't matter whether a rejudging is valid, only whether a judging is associated with one. Fixes DOMjudge#3069.
|
Thanks, fixed. |
|
From the commit message now:
so I understand that the But it's fine, no objections to merging. |
|
It returns true when it needs more work. I will see how to add some comments in judgedaemon to make this more clear. |
3 participants
Fixes #3069.