Fix codestyle errors #3146
Fix codestyle errors #3146
Conversation
| } | ||
| } | ||
| elseif ($this->config->get('check_new_version', false) === UpdateStrategy::Strategy_major_release) { | ||
| } elseif ($this->config->get('check_new_version', false) === UpdateStrategy::Strategy_major_release) { |
There was a problem hiding this comment.
| } elseif ($this->config->get('check_new_version', false) === UpdateStrategy::Strategy_major_release) { | |
| } elseif ( | |
| $this->config->get('check_new_version', false) === UpdateStrategy::Strategy_major_release | |
| ) { |
I do think this is only slightly better. I would keep the original line.
There was a problem hiding this comment.
For me the line doesn't feel too long but if others think it does, we should come up with a way to make it shorter. I really don';t think the original, which saves 2 characters but has the } weirdly on its own line, makes it better.
There was a problem hiding this comment.
If these enums are always written like UpdateStrategy::Strategy_major_release, then why does it contain "strategy" twice? Removing that would fix this case and in general produce shorter lines.
There was a problem hiding this comment.
I think that makes sense and is indeed beter to read
There was a problem hiding this comment.
Alternative is to shorten UpdateStrategy to US for this inclusion. I think we shouldn't change this though.
| if ($tmpValue === null) continue; | ||
| if ($tmpValue === null) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I think that short statements like this are shorter and clearer as is.
| * Call ob_flush() unless the top-level output buffer does not allow it. | ||
| */ | ||
| public static function ob_flush_if_possible(): bool | ||
| public static function ob_flush_if_possible(): bool // phpcs:ignore PSR1.Methods.CamelCapsMethodName.NotCamelCaps |
There was a problem hiding this comment.
I mentioned this one in slack, but I see it's already annotated. I wrote it like this on purpose snice it wraps ob_flush.
3 participants
No description provided.