Mydspace

[atarix83]

This PR implements MyDSpace page.

This PR must be test against this REST PR DSpace/DSpace#2391 and can be merged only after the REST PR is merged in the master.

To test this PR please use an environment where configurable workflow is properly configured.

There is a known issue while trying to deposit a workspaceitems to a collection without a configured workflow. Issue depends on a problem on REST side and has already reported here to resolve it

[atarix83]

@artlowel

The browse link is lower than the rest of the text by a few px. The new submission button is higher than the drop-box by a few px.

They should be aligned now

The validation label at the top is squared with rounded corners, the submitter name label is entirely rounded.

Fixed

there is not enough spacing, e.g. between the Edit/Delete/Approve/Reject/Return to pool buttons

Fixed

[tdonohue]

@atarix83 : I gave this a quick test today as well (against the latest master code). I'm seeing the same error that @paulo-graca reported here whenever I attempt to click "Deposit" on an in-progress submission (/workspaceitems/[id]/edit). However, if I manually return to the MyDSpace page, I do see that the Item is moved to the "Archived" status (so the deposit was successful, even though I saw an error message).

I've also found I cannot drag & drop a PDF onto the MyDSpace page (/mydspace?configuration=workspace). Doing so results in an error that says "Error creating new workspace. Please verify the content uploaded before retry." However, I can successfully drag & drop a PDF into an active New Submission (/submit or /workspaceitems/[id]/edit). It only seems to fail from the MyDSpace page.

Beyond those two oddities in testing, the rest of the features seem to work well. Thanks!

[artlowel]

Thanks @atarix83!

The search issue I reported is fixed, and you've taken aboard all of my suggestions.

I can also reproduce the issues @paulo-graca en @tdonohue reported though (depositing an in-progess submission and adding a pdf on mydspace both cause error notifications)

[atarix83]

@tdonohue @artlowel @paulo-graca

I've checked issue with depositing an in-progess submission and problem occurs even with depositing a new one. However it happens only when trying to submit to a collection without a defined workflow and is not related to this PR but is due to a REST side issue that has already been reported here

[atarix83]

@tdonohue

I've also found I cannot drag & drop a PDF onto the MyDSpace page (/mydspace?configuration=workspace). Doing so results in an error that says "Error creating new workspace. Please verify the content uploaded before retry." However, I can successfully drag & drop a PDF into an active New Submission (/submit or /workspaceitems/[id]/edit). It only seems to fail from the MyDSpace page.

this should be fixed now

[tdonohue]

@atarix83 : Just a note, it looks like your most recent changes accidentally broke the build of this PR. See Travis builds: https://travis-ci.org/DSpace/dspace-angular/builds/527355394

[abollini]

@tdonohue the failure are due to the down of the rest api demo site that has been caused by the recent update as we haven't yet had the time to switch to solr7

[artlowel]

@tdonohue

I've also found I cannot drag & drop a PDF onto the MyDSpace page (/mydspace?configuration=workspace). Doing so results in an error that says "Error creating new workspace. Please verify the content uploaded before retry." However, I can successfully drag & drop a PDF into an active New Submission (/submit or /workspaceitems/[id]/edit). It only seems to fail from the MyDSpace page.

this should be fixed now

I've retested and verified that it's fixed. Thanks @atarix83!

[artlowel]

I've approved this PR, in order for us to move ahead with the preview release, but I want to note a couple of things we still need to address after it has been merged.

• The way roles have been included here, with hardcoded roles and a lot of logic on the client-side should be addressed, both on the rest and the UI side (comment #1 / #2) → Roles are hardcoded in the UI #393
• forceBypassCache should be removed from the requestService (comment) → forceBypassCache should be removed from the RequestService #394
• It seems the rest api embeds objects the UI can't use and they need to be filtered from the response (comment) → this is for performance reasons, as explained by @atarix83 here
• TaskService extends DataService, but adds its own parallel post and delete methods that work slightly differently (comment #1 / #2) → TasksService implements its own Post and Delete methods. #395

Edit: added links to issues

[tdonohue]

@artlowel : could you turn those actions into tickets? I think it'd be worth capturing them so that they are not forgotten.

I'd also like to see this PR merged ASAP. I was hoping we could first get the demo REST API back up and running though, so we can see Travis CI approve this PR. Longer term, this points out the obvious (and known) problem with our tests -- they are dependent on an external server. We will need to prioritize a resolution to that issue, so that future PRs are not put in a similar state as this one.

[paulo-graca]

Thank you @atarix83 for addressing my comments. But I can only test this again this Friday. I will give a second look.

[atarix83]

@tdonohue PR build is successful again

@artlowel thanks for approving, only a comment on your note :

It seems the rest api embeds objects the UI can't use and they need to be filtered from the response

it's only a filter to parse only useful objects, how it was done on public search https://github.com/4Science/dspace-angular/blob/mydspace/src/app/core/data/search-response-parsing.service.ts#L58

[atarix83]

@tdonohue @artlowel @paulo-graca
I've changed the default rest host to point to new rest demo with solr 7 https://dspace7.4science.cloud/dspace-spring-rest/#/dspace-spring-rest/api

[tdonohue]

👍 I've retested today, and the bugs I previously found have been resolved (other than the bug related to Collections without a workflow, but that's a REST API bug logged in DS-4210). So, to me, this looks ready to merge.

As noted by @artlowel above, there are a few outstanding minor issues, but those can be logged as minor bugs and resolved in follow-up PRs.

As @paulo-graca has noted above that he wants to review this again on Friday (tomorrow), I will leave this PR open for one more day. I'll merge it tomorrow, or whenever Paulo has had a chance to do his final review.

[paulo-graca]

I don't know if it's because of my database (which have entities) but I'm getting several errors with this PR, like:

Error: The server returned an invalid object
    at DSOResponseParsingService../src/app/core/data/base-response-parsing.service.ts.BaseResponseParsingService.addToObjectCache (base-response-parsing.service.ts:113)
    at 
....

But since @tdonohue and @artlowel already gave their thumbs up. I think this PR it's in the condition to be merged.

[tdonohue]

@paulo-graca : Thanks for the notes. As both this PR and the Entities one (#372) are set to merge today, it's possible that some of what you are seeing will be worked out once we get both of these in master. However, It'd obviously be good for you (and everyone else) to test everything again once it is all merged...it's very possible we'll end up with minor bugs between these big PRs (which we can get resolved ASAP).

So, I'll move ahead and get this merged & Entities work merged. Then notify everyone to retest master to see if we notice any bugs that need squashing.