Fix pots freezing if a harvest cycle completes and no drops are collected. #273

Author: Darkhax

Common/src/main/java/net/darkhax/botanypots/block/BlockEntityBotanyPot.java

@@ -31,6 +31,7 @@
 import net.minecraft.world.level.block.state.BlockState;
 
 import javax.annotation.Nullable;
+import java.util.List;
 import java.util.Random;
 
 public class BlockEntityBotanyPot extends WorldlyInventoryBlockEntity<BotanyPotContainer> {
@@ -129,15 +130,21 @@ public boolean isValidSeed(ItemStack stack) {
 
     public boolean attemptAutoHarvest() {
 
-        boolean didCollect = false;
-
         if (this.getLevel() != null && !this.getLevel().isClientSide && this.getCrop() != null) {
 
             final ContainerInventoryAccess<BotanyPotContainer> inventory = new ContainerInventoryAccess<>(this.getInventory());
 
             this.rng.setSeed(this.rngSeed);
+            final List<ItemStack> drops = BotanyPotHelper.generateDrop(rng, this.level, this.getBlockPos(), this, this.getCrop());
+
+            if (drops.isEmpty()) {
+
+                return true;
+            }
 
-            for (ItemStack drop : BotanyPotHelper.generateDrop(rng, this.level, this.getBlockPos(), this, this.getCrop())) {
+            boolean didCollect = false;
+
+            for (ItemStack drop : drops) {
 
                 if (!drop.isEmpty()) {
 
@@ -159,9 +166,11 @@ public boolean attemptAutoHarvest() {
                     }
                 }
             }
+
+            return didCollect;
         }
 
-        return didCollect;
+        return false;
     }
 
     private void attemptExport() {