Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color preview not working properly. #2606

Closed
brc-dd opened this issue Jul 4, 2020 · 0 comments · Fixed by #2615
Closed

Color preview not working properly. #2606

brc-dd opened this issue Jul 4, 2020 · 0 comments · Fixed by #2615
Labels
in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug
Milestone

Comments

@brc-dd
Copy link

brc-dd commented Jul 4, 2020

I am experiencing some issues with the preview boxes showing colors left to any Color object.

What I am getting:

image
image

What I should be getting:

image

Clearly the issue is because whatever code you guys are using to generate color in that square box is not checking if the Color object is there in comment. It is simply finding all Color objects as if in plaintext and mapping them to line numbers; the color which is found last in a line is retained as the key and rest are discarded.

VS Code Setup Information:

Version: 1.47.0-insider (user setup)
Commit: 376d9d9d785ccca128fdbb16f001446d0ad64d32
OS: Windows_NT x64 10.0.19041

Extension Versions:

dart-code.dart-code : v3.12.1
dart-code.flutter : v3.12.1

@DanTup DanTup added this to the v3.13.0 milestone Jul 6, 2020
@DanTup DanTup added in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug labels Jul 6, 2020
DanTup pushed a commit that referenced this issue Jul 8, 2020
Also handle whitespace and multi-line breaking.

Fixes #2606.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants