[suse] Import the new GPG key #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the near future, we're going to sign our RPM packages with our newer GPG key. The RHEL task already imports the new key, but not the SUSE task, so the new key import step has been added to it.
hush-hush
suggested changes
Aug 8, 2019
Member
hush-hush
left a comment
hush-hush
left a comment
There was a problem hiding this comment.
Could you also update the CHANGELOG and the README to add a bit of documentation ?
defaults/main.yml
Outdated
| datadog_zypper_repo: "https://yum.datadoghq.com/suse/stable/6/{{ ansible_userspace_architecture }}" | ||
| datadog_zypper_gpgkey: "https://yum.datadoghq.com/DATADOG_RPM_KEY.public" | ||
| datadog_zypper_gpgkey_sha256sum: "00d6505c33fd95b56e54e7d91ad9bfb22d2af17e5480db25cba8fee500c80c46" | ||
| datadog_zypper_gpgkey_new: "https://yum.datadoghq.com/DATADOG_RPM_KEY_E09422B3.public" |
Member
There was a problem hiding this comment.
Could we rename the variable for something without new like datadog_zypper_gpgkey_E09422B3 (in order to preprare for the next key rotation) ?
hush-hush
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the near future, we're going to sign our RPM packages with our
newer GPG key. The RHEL task already imports the new key, but not the SUSE
task, so the new key import step has been added to it.