Ensure that system-probe is stopped if it is disabled or not installed #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shang-wang
approved these changes
Jan 16, 2020
KSerrania
reviewed
Jan 17, 2020
| name: datadog-agent-sysprobe | ||
| state: stopped | ||
| enabled: no | ||
| when: not datadog_skip_running_check and (not datadog_enabled or not datadog_sysprobe_enabled) |
Contributor
There was a problem hiding this comment.
Let's prevent this from running when ansible is in check mode (same as the running check above):
Suggested change
| when: not datadog_skip_running_check and (not datadog_enabled or not datadog_sysprobe_enabled) | |
| when: not datadog_skip_running_check and not ansible_check_mode and (not datadog_enabled or not datadog_sysprobe_enabled) |
Contributor
Author
There was a problem hiding this comment.
The reason I omitted that is the task to stop the main agent does not include it.
Does it still make sense to include?
Contributor
There was a problem hiding this comment.
I'd say this is an error, as this means the role may do something when run in check mode (for instance, if an Agent was running on the target host, the role may stop it).
But for now, let's keep the role behaviour coherent and leave this out. I'll investigate this in another PR.
KSerrania
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the system probe is not installed or is explicitly disabled, we should ensure that the service is stopped.
This covers the use case where the probe had been previously enabled and then disabled.