Add installation of new debian and GPG keys #308
Conversation
tasks/pkg-suse.yml
Outdated
| - name: Stat if 20200908 key (Expires 2024) RPM key already exists | ||
| stat: | ||
| path: /tmp/DATADOG_RPM_KEY_20200908.public | ||
| register: ddnewkey |
There was a problem hiding this comment.
Is it fine to register ddnewkey twice (once for the E09422B3 key, once for 20200908)? If it's being overridden, that should be okay (but we need an SLES 11 box to test).
We can also decide to use another variable name (eg. ddkey_20200908) to be sure there won't be any conflict.
| enabled: yes | ||
| gpgcheck: yes | ||
| gpgkey: "{% if datadog_agent_major_version|int == 7 %}{{ datadog_yum_gpgkey_e09422b3 }}{% else %}{{ datadog_yum_gpgkey }}{% endif %}" | ||
| gpgkey: "{% if datadog_agent_major_version|int == 7 %}{{ datadog_yum_gpgkey_20200908 }}{% else %}{{ datadog_yum_gpgkey }}{% endif %}" |
There was a problem hiding this comment.
I don't know which one should be put here TBH. Is there a way to specify multiple keys here? If there is, we should put all keys there. If not, I guess we should still put the currently used key (e09422b3) since that's the key people need right now. The steps above will ensure that the future key is present.
There was a problem hiding this comment.
If I understand correctly (and that's a big if)
- This line is actually not necessary due to the manual import steps above
- Since we're manually importing both keys above, it will work either way
- I chose the most recent key so that when the older key expires it doesn't cause problems
Disambiguate returns of different stages
No description provided.