Make windows package download behavior consistent with linux #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip download in check mode
Contributor
|
Hi! Thanks for sending the PR. It looks good, but I think we'll also need https://github.com/DataDog/ansible-datadog/pull/359/files#diff-bef70ee7f6fc30d9bf9be97dd8eaff36eb544b6e51dd36dc3be66f7e4f07610bR105 (the |
Contributor
Author
|
thanks for catching that @bkabrda, i've added that conditional. |
bkabrda
reviewed
May 19, 2021
Co-authored-by: Slavek Kabrda <slavek.kabrda@gmail.com>
Contributor
|
LGTM now, merging. Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip download in check mode on windows as linux installs do.
This will reporting a changed task in check mode when agent version is current.